Skip to content

Multibuffer breadcrumbs toolbar redesign #45547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danilo-leal merged 37 commits into from
Jan 6, 2026
Merged

Multibuffer breadcrumbs toolbar redesign #45547

danilo-leal merged 37 commits into from
Jan 6, 2026

Conversation

@KyleBarton
Copy link
Collaborator

@KyleBarton KyleBarton commented Dec 23, 2025

Breadcrumb visual reorchestration which makes a couple of key changes:

  • Breadcrumbs are now displayed in file headers for multibuffer views. Singleton buffers are unchanged.
  • Multibuffer views now have collapse/expand all buttons available in the toolbar
  • Search in multibuffer views now takes up less space, by occupying the primary toolbar location erstwhile taken up by breadcrumbs
Screenshot 2025-12-22 at 4 15 41 PM Screenshot 2025-12-22 at 4 15 51 PM

Release Notes:

  • Moved breadcrumbs to file headers in multibuffer views
  • Added collapse/expand all options for multibuffer views
  • Improved use of space for multibuffer search by taking the place of the former breadcrumb toolbar location
KyleBarton and others added 16 commits December 16, 2025 15:30
@KyleBarton
Initial pass at clearing up the toolbar in the multibuffer case. Brea…
0ca9209 
…dcrumbs to sticky headers.
@KyleBarton
Clean up imports, and leave a note-to-self on refactoring improvement.
3f92a1c
@KyleBarton @danilo-leal
Remove breadcrumbs from project_search; add collapse/expand to its
70383b4 
render.

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
@KyleBarton @danilo-leal
First pass at solving search positioning. Good except for buffer sear…
ec7a8e8 
…ch in project search.

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
@KyleBarton
Check for project_search in editor to determine search bar positioning.
c46eed6
@KyleBarton
Toggle collapse/expand button based on editor actions. Refactor foldi…
c01513e 
…ng logic.
@KyleBarton
cx.notify for better rendering performance.
037e2d6
@KyleBarton
Merge branch 'main' into multibuffer_breadcrumbs_toolbar_redesign
823c810
@KyleBarton
Fix build. Add truncate_start to buffer headers filepath.
f2a3474
@KyleBarton
Prevent breadcrumbs from overflowing into action buttons in sticky he…
a66cc14 
…ader.
@KyleBarton
Remove old comment.
8a5a820
@KyleBarton
Test changes to BufferSearchBar
1ca97a9
@KyleBarton
Test project_search changes
3e853e8
@KyleBarton
Simplify factored out editor item implementation
626aa23
@KyleBarton
Cleanup unused breadcrumb logic
a17cd99
@KyleBarton
Dedupe rendering logic for breadcrumbtext segments.
5e414ba
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 23, 2025
@danilo-leal danilo-leal merged commit 216933f into main Jan 6, 2026
23 checks passed
@danilo-leal danilo-leal deleted the multibuffer_breadcrumbs_toolbar_redesign branch January 6, 2026 12:42
rtfeldman pushed a commit that referenced this pull request Jan 6, 2026
@KyleBarton @danilo-leal
@zed-zippy @rtfeldman
Multibuffer breadcrumbs toolbar redesign (#45547)
a595a18 
Breadcrumb visual reorchestration which makes a couple of key changes:
- Breadcrumbs are now displayed in file headers for multibuffer views.
Singleton buffers are unchanged.
- Multibuffer views now have collapse/expand all buttons available in
the toolbar
- Search in multibuffer views now takes up less space, by occupying the
primary toolbar location erstwhile taken up by breadcrumbs

<img width="1721" height="823" alt="Screenshot 2025-12-22 at 4 15 41 PM"
src="https://github.com/user-attachments/assets/38e924f7-fe9e-4c83-84fb-2eee98137f43"
/>

<img width="1722" height="762" alt="Screenshot 2025-12-22 at 4 15 51 PM"
src="https://github.com/user-attachments/assets/ccc98ca3-75ce-4aca-bceb-890817b0f04d"
/>


Release Notes:

- Moved breadcrumbs to file headers in multibuffer views
- Added collapse/expand all options for multibuffer views
- Improved use of space for multibuffer search by taking the place of
the former breadcrumb toolbar location

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Zed Zippy <234243425+zed-zippy[bot]@users.noreply.github.com>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
@KyleBarton @danilo-leal @zed-zippy
Multibuffer breadcrumbs toolbar redesign (zed-industries#45547)
f39b72b 
Breadcrumb visual reorchestration which makes a couple of key changes:
- Breadcrumbs are now displayed in file headers for multibuffer views.
Singleton buffers are unchanged.
- Multibuffer views now have collapse/expand all buttons available in
the toolbar
- Search in multibuffer views now takes up less space, by occupying the
primary toolbar location erstwhile taken up by breadcrumbs

<img width="1721" height="823" alt="Screenshot 2025-12-22 at 4 15 41 PM"
src="https://github.com/user-attachments/assets/38e924f7-fe9e-4c83-84fb-2eee98137f43"
/>

<img width="1722" height="762" alt="Screenshot 2025-12-22 at 4 15 51 PM"
src="https://github.com/user-attachments/assets/ccc98ca3-75ce-4aca-bceb-890817b0f04d"
/>


Release Notes:

- Moved breadcrumbs to file headers in multibuffer views
- Added collapse/expand all options for multibuffer views
- Improved use of space for multibuffer search by taking the place of
the former breadcrumb toolbar location

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Zed Zippy <234243425+zed-zippy[bot]@users.noreply.github.com>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
@KyleBarton @danilo-leal @zed-zippy
Multibuffer breadcrumbs toolbar redesign (zed-industries#45547)
164294d 
Breadcrumb visual reorchestration which makes a couple of key changes:
- Breadcrumbs are now displayed in file headers for multibuffer views.
Singleton buffers are unchanged.
- Multibuffer views now have collapse/expand all buttons available in
the toolbar
- Search in multibuffer views now takes up less space, by occupying the
primary toolbar location erstwhile taken up by breadcrumbs

<img width="1721" height="823" alt="Screenshot 2025-12-22 at 4 15 41 PM"
src="https://github.com/user-attachments/assets/38e924f7-fe9e-4c83-84fb-2eee98137f43"
/>

<img width="1722" height="762" alt="Screenshot 2025-12-22 at 4 15 51 PM"
src="https://github.com/user-attachments/assets/ccc98ca3-75ce-4aca-bceb-890817b0f04d"
/>


Release Notes:

- Moved breadcrumbs to file headers in multibuffer views
- Added collapse/expand all options for multibuffer views
- Improved use of space for multibuffer search by taking the place of
the former breadcrumb toolbar location

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Zed Zippy <234243425+zed-zippy[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

3 participants

@KyleBarton @danilo-leal