languages: Escape test names for bun runner #45749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
pckilgore
commented
Dec 27, 2025
Contributor
Author
There was a problem hiding this comment.
This is the same implementation I found for, e.g., TYPESCRIPT_VITEST_TEST_NAME_VARIABLE
versecafe
reviewed
Dec 31, 2025
Contributor
versecafe
left a comment
versecafe
left a comment
There was a problem hiding this comment.
I believe the issue also exists for the node:test setup this slipped through the cracks when I added support for the two if you could patch that in this PR as well would be great.
Member
|
Thanks! |
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
Closes #45746 Release Notes: - Fixed un-escaped regexp characters in test names passed to `bun test`
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
Closes zed-industries#45746 Release Notes: - Fixed un-escaped regexp characters in test names passed to `bun test`
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
Closes zed-industries#45746 Release Notes: - Fixed un-escaped regexp characters in test names passed to `bun test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45746
Release Notes:
bun test