keymap_editor: Add a "create keybinding" modal #46030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
Ever since we launched the keymap editor, we've received feedback about how "_creating_" a new keybinding was not obvious. At first, I was confused about this feedback because you can't "create" a keybinding, you need to rather _assign it_ to an action... so what always made sense to me was to start with searching for the action, which is an use case we already support. Regardless, having an easy to reach "create" button, which essentially still asks for action > keystroke > arguments (if needed) > and context, feels like a win UX-wise; a bit of a redundant flow that feels ultimately positive. So, this PR adds a "Create Keybinding" button to the keymap editor, which you can reach with `cmd-k`. That will open up a modal with an action autocomplete, the keystroke recording input, the arguments input (if needed), and the context input. https://github.com/user-attachments/assets/86f64314-4685-47bb-bb0d-72ca4c469d1f Release Notes: - keymap editor: Added a keybinding creation modal to make it easier to assign an action to a keystroke.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
Ever since we launched the keymap editor, we've received feedback about how "_creating_" a new keybinding was not obvious. At first, I was confused about this feedback because you can't "create" a keybinding, you need to rather _assign it_ to an action... so what always made sense to me was to start with searching for the action, which is an use case we already support. Regardless, having an easy to reach "create" button, which essentially still asks for action > keystroke > arguments (if needed) > and context, feels like a win UX-wise; a bit of a redundant flow that feels ultimately positive. So, this PR adds a "Create Keybinding" button to the keymap editor, which you can reach with `cmd-k`. That will open up a modal with an action autocomplete, the keystroke recording input, the arguments input (if needed), and the context input. https://github.com/user-attachments/assets/86f64314-4685-47bb-bb0d-72ca4c469d1f Release Notes: - keymap editor: Added a keybinding creation modal to make it easier to assign an action to a keystroke.
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
Ever since we launched the keymap editor, we've received feedback about how "_creating_" a new keybinding was not obvious. At first, I was confused about this feedback because you can't "create" a keybinding, you need to rather _assign it_ to an action... so what always made sense to me was to start with searching for the action, which is an use case we already support. Regardless, having an easy to reach "create" button, which essentially still asks for action > keystroke > arguments (if needed) > and context, feels like a win UX-wise; a bit of a redundant flow that feels ultimately positive. So, this PR adds a "Create Keybinding" button to the keymap editor, which you can reach with `cmd-k`. That will open up a modal with an action autocomplete, the keystroke recording input, the arguments input (if needed), and the context input. https://github.com/user-attachments/assets/86f64314-4685-47bb-bb0d-72ca4c469d1f Release Notes: - keymap editor: Added a keybinding creation modal to make it easier to assign an action to a keystroke.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since we launched the keymap editor, we've received feedback about how "creating" a new keybinding was not obvious. At first, I was confused about this feedback because you can't "create" a keybinding, you need to rather assign it to an action... so what always made sense to me was to start with searching for the action, which is an use case we already support. Regardless, having an easy to reach "create" button, which essentially still asks for action > keystroke > arguments (if needed) > and context, feels like a win UX-wise; a bit of a redundant flow that feels ultimately positive.
So, this PR adds a "Create Keybinding" button to the keymap editor, which you can reach with
cmd-k. That will open up a modal with an action autocomplete, the keystroke recording input, the arguments input (if needed), and the context input.Screenshot.2026-01-04.at.2.24.mp4
Release Notes: