Skip to content

windows: Improve error message for credential write failures #46221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Veykril merged 1 commit into from
Jan 8, 2026
Merged

windows: Improve error message for credential write failures #46221

Veykril merged 1 commit into from
Jan 8, 2026

Conversation

@cppcoffee
Copy link
Contributor

@cppcoffee cppcoffee commented Jan 7, 2026

Release Notes:

  • Improved Display the actual Windows error message when writing credentials to Credential Manager fails, instead of the generic "Failed to write API key to keychain" message. This helps users diagnose issues like permission problems.
@cppcoffee
windows: Improve error message for credential write failures
f7c21cd 
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 7, 2026
@cppcoffee
Copy link
Contributor Author

cppcoffee commented Jan 7, 2026 •
edited
Loading

Before:

0eb697d43463897bb4067dd84b74fdf8
@cppcoffee cppcoffee marked this pull request as draft January 7, 2026 02:12
@cppcoffee cppcoffee marked this pull request as ready for review January 7, 2026 13:47
@Veykril Veykril enabled auto-merge (squash) January 8, 2026 09:51
@Veykril Veykril merged commit cfa478d into zed-industries:main Jan 8, 2026
24 checks passed
@cppcoffee cppcoffee deleted the errmsg branch January 8, 2026 10:25
rtfeldman pushed a commit that referenced this pull request Jan 9, 2026
@cppcoffee @rtfeldman
windows: Improve error message for credential write failures (#46221)
2ce3aa7 
Release Notes:

- Improved Display the actual Windows error message when writing
credentials to Credential Manager fails, instead of the generic "Failed
to write API key to keychain" message. This helps users diagnose issues
like permission problems.

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
@cppcoffee
windows: Improve error message for credential write failures (zed-ind…
9c116f2 
…ustries#46221)

Release Notes:

- Improved Display the actual Windows error message when writing
credentials to Credential Manager fails, instead of the generic "Failed
to write API key to keychain" message. This helps users diagnose issues
like permission problems.

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
@cppcoffee
windows: Improve error message for credential write failures (zed-ind…
bb14f73 
…ustries#46221)

Release Notes:

- Improved Display the actual Windows error message when writing
credentials to Credential Manager fails, instead of the generic "Failed
to write API key to keychain" message. This helps users diagnose issues
like permission problems.

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

2 participants

@cppcoffee @Veykril