terminal: Fix last character of IME marked text not being deleted #46224
+8
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
github-actions
bot
added
the
community champion
maxdeviant
changed the title
Member
|
I don't have a Mac to test with, but assuming my suggestion still fixes the issue, this looks good to me. Ideally we would implement the rest of this interface properly (e.g. adding a 'virtual' cursor that lets you move around in the marked text) but this is a good improvement. |
Contributor
Author
|
Thanks! I've adjusted the code following your suggestion and verified it's still working on Mac. CleanShot.2026-01-14.at.11.28.27.mp4 |
rtfeldman
pushed a commit
that referenced
this pull request
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46084
I'm not very familiar with this part of the code, so I'm not sure if this is the right way to fix it.
During debugging, I discovered that
marked_range_utf16consistently stores an empty range representing the cursor position (e.g.,0..0,1..1) instead of an actual marked range. This bug is caused by the range being empty.In my testing, the IME starts working correctly as long as I change it to any non-empty range (e.g.,
0..1). Although I suspect the correct value should probably be0..marked_text.encode_utf16().count().Before/After:
CleanShot.2026-01-07.at.10.36.51.mp4
Release Notes: