vim: Allow trailing whitespace for :norm command
#46403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
github-actions
bot
added
the
community champion
|
Thanks a lot for handling this! |
- Update `args()` and `filename()` doc comments to accurately describe their effect on whitespace handling - Flatten nested if/else in `parse()` to an if/else if/else chain
Member
|
Thank you @AidanV ! 🎉 |
dinocosta
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a bug with
:normthat disallowed trailing whitespace.Previous Zed behavior:
Neovim behavior:
Thank you to @woza4961 in the Zed Discord for the GIFs!
Zed's behavior now matches Neovim's.
I decided to let Commands that accept generic args (i.e. commands defined with the
argsfunction) to handle trailing whitespace themselves, and those that accept filenames (i.e. commands defined with thefilenamefunction) to have whitespace pre-trimmed. This allows for us to ignore it in the general case (filenames) and only care about whitespace when we want to do something special like:norm.The only other Command that calls the
argsfunction is:delmarkswhich is not affected by this change since marks cannot be whitespace.Release Notes:
:normcommand to preserve trailing whitespace in arguments (e.g.,:norm Inow correctly inserts two spaces)