Properly notify all language server worktree trust listeners (#46613) (cherry-pick to stable) #46615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #46590 https://github.com/user-attachments/assets/8464a3b6-9258-4d15-9168-56178bf46437 `use smol::channel::{Receiver, Sender};` do not propagate the value change to all receivers, hence only one language server received the "worktree trusted" message. The fix uses `watch` kind of channels instead, and cleans up its state more eager to rely on the sender drop as another form of notification. Release Notes: - Fixed groups of language servers not starting after worktree trust approval
cla-bot
bot
added
the
cla-signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #46613 to stable
Closes #46590
trust_all.mov
use smol::channel::{Receiver, Sender};do not propagate the valuechange to all receivers, hence only one language server received the
"worktree trusted" message.
The fix uses
watchkind of channels instead, and cleans up its statemore eager to rely on the sender drop as another form of notification.
Release Notes:
approval