Skip to content

agent_ui: Make stopping a running terminal cancel thread generation #46663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danilo-leal merged 1 commit into from
Jan 13, 2026
Merged

agent_ui: Make stopping a running terminal cancel thread generation #46663

danilo-leal merged 1 commit into from
Jan 13, 2026

Conversation

@danilo-leal
Copy link
Member

@danilo-leal danilo-leal commented Jan 12, 2026

This makes stopping a terminal tool call in the agent panel also cancel the thread generation:

Screenshot.2026-01-12.at.8.23.mp4

Release Notes:

  • Agent: Made the act of stopping a terminal tool call in the agent panel also cancel the thread generation.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 12, 2026
@danilo-leal danilo-leal enabled auto-merge (squash) January 12, 2026 23:34
@danilo-leal danilo-leal merged commit 70da176 into main Jan 13, 2026
37 of 40 checks passed
@danilo-leal danilo-leal deleted the stop-terminal-stop-thread branch January 13, 2026 11:43
@sarmel
Copy link

sarmel commented Jan 16, 2026 •
edited
Loading

Please make it configurable. I personally wouldn't enable this.
@MrPointer
Copy link

MrPointer commented Jan 22, 2026 •
edited
Loading

Oh no... That's not the behavior I want at all!
Sometimes the model runs tools that hang forever, e.g. it tries to write concurrent code but accidentally creates a deadlock, so when it tests this code, via a tool call, it hangs forever until I manually stop it. It then captures the stop, analyzes how much time it took, and realizes that something's not right, and usually is smart enough to detect the deadlock and resolve it. With this change, that would be made impossible! (or require at least another prompt, which in some plans like Copilot, can be highly costly)

So adding to @sarmel's comment, this should be configurable, as surely we don't all agree that this should be the only behavior.
@danilo-leal danilo-leal mentioned this pull request Jan 23, 2026
Merged
danilo-leal added a commit that referenced this pull request Jan 23, 2026
@danilo-leal
agent: Add setting for controlling terminal tool stop button behavior (…
19b4e43 
…#47521)

Addressing the feedback left on a previous PR of mine:
#46663. I feel like this is
worthy of a setting. Note, however, that this does not apply to typing
`ctrl-c` in the terminal from within the agent panel; this is purely
controlling what happens when you click on the "Stop" button in the
terminal tool call card.

Release Notes:

- Agent: Added a setting for controlling the behavior of the stop button
in the terminal tool call card (between cancelling the command to run
and the thread, or just the command).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

4 participants

@danilo-leal @sarmel @MrPointer