workspace: Fix tab reordering regression (#46872) (cherry-pick to preview) #46878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes [#46864](#46864) Initial PR: #46573 ## Summary Fix a regression where dragging a tab onto another tab would place it at the end of the tab bar instead of at the target position. The issue was in the `on_drop` handler: it used `this.items.len()` (evaluated at drop time) instead of the captured `ix` index (the position of the tab being dropped onto). Release Notes: - Fixed tab reordering not working correctly when dragging tabs ## Video after fix: - when 'show_pinned_tabs_in_separate_row' is false: https://github.com/user-attachments/assets/1ede0ce5-1161-4209-83f4-33a07572782a - when 'show_pinned_tabs_in_separate_row' is true: https://github.com/user-attachments/assets/d56c0e59-8372-41d4-973b-32a4895ca729 --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
cla-bot
bot
added
the
cla-signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #46872 to preview
Closes #46864
Initial PR: #46573
Summary
Fix a regression where dragging a tab onto another tab would place it at
the end of the tab bar instead of at the target position.
The issue was in the
on_drophandler: it usedthis.items.len()(evaluated at drop time) instead of the captured
ixindex (theposition of the tab being dropped onto).
Release Notes:
Video after fix:
Screen.Recording.2026-01-15.at.09.29.38.mov
Screen.Recording.2026-01-15.at.09.30.18.mov
Co-authored-by: Smit Barmase heysmitbarmase@gmail.com