remote: Support opening builtin host files in remote workspaces #46910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Veykril
force-pushed
the
push-zynpswlznyvs
branch
2 times, most recently
from
f541ca8 to
ed5a1d9
Compare
Veykril
force-pushed
the
push-zynpswlznyvs
branch
from
ed5a1d9 to
64c5433
Compare
Veykril
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to open read-only builtin files (like bundled ones, or the logs) in remote windows, since we can just upload the text from the client there.
Additionally for mutable builtin files like the user settings, we can open these in wsl remote windows, as wsl mounts the host filesystem allowing us to access it from within the vm.
Release Notes: