Skip to content

wifi_cred: Enterprise support is incomplete #91790

@krish2718

Description

@krish2718

Describe the bug

Few issues while looking at Wi-Fi cred: https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/net/lib/wifi_credentials/wifi_credentials.c

  • All APIs are still named _personal
  • Only APIs wifi_credentials_get_by_ssid_personal_struct/wifi_credentials_get_by_ssid_personal_struct that are used by Wi-Fi cred shell have been extended to support Enterprise
  • Non-Shell APIs: wifi_credentials_set_personal/wifi_credentials_get_by_ssid_personal are still purely personal (both and functionality)
  • Tests https://github.com/zephyrproject-rtos/zephyr/tree/main/tests/net/lib/wifi_credentials have not been updated with Entreprise support

We should also revisit two variant of APIs regular (args) vs _struct (struct), not sure what was the motivation, but IMHO, we can make _struct as the standard (and may be drop _struct from the API name?).

Regression

  • This is a regression.

Steps to reproduce

No response

Relevant log output

Impact

Functional Limitation – Some features not working as expected, but system usable.

Environment

No response

Additional Context

No response

Metadata

Metadata

Labels

EnhancementChanges/Updates/Additions to existing featuresMetaA collection of features, enhancements or bugsarea: Wi-FiWi-Fi

Projects

Status

Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions