tests: benchmark: mbedtls: remove legacy crypto Kconfig#102042
tests: benchmark: mbedtls: remove legacy crypto Kconfig#102042MaureenHelm merged 1 commit intozephyrproject-rtos:mainfrom
Conversation
This is a leftover from the past that is no more required and that should be removed in order to prepare for the next Mbed TLS release. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
zephyrbot
added
area: Tests
zephyrbot
requested review from
ceolin,
d3zd3z,
dcpleung,
ithinuel,
nashif,
peter-mitsis,
tomi-font and
wearyzen
|
| CONFIG_MBEDTLS=y | ||
| CONFIG_MBEDTLS_PSA_CRYPTO_C=y |
There was a problem hiding this comment.
While we're at it, how about changing this to CONFIG_PSA_CRYPTO=y?
There was a problem hiding this comment.
Well I see the folder's called mbedtls so maybe we'd then need to rename it as well...
There was a problem hiding this comment.
I left these Kconfigs intentionally when I reshaped this benchmark. The idea of this test was to benchmark the performance of Mbed TLS so I wanted to keep the same goal. That's why I kept the selection of CONFIG_MBEDTLS and CONFIG_MBEDTLS_PSA_CRYPTO_C instead of the newer CONFIG_PSA_CRYPTO.
Do you think it's worth to make the scope of this test broader?
There was a problem hiding this comment.
Yeah makes sense, I think we actually even already discussed this haha, fine as is, could be worth generalizing to any PSA Crypto provider (I don't think it'd be much work?) but not in the scope of this PR.
6 participants
This is a leftover from the past that is no more required and that should be removed in order to prepare for the next Mbed TLS release.