Bluetooth: Controller: consolidated next changes#102058
Draft
cvinayak wants to merge 64 commits intozephyrproject-rtos:mainfrom
Draft
Bluetooth: Controller: consolidated next changes#102058cvinayak wants to merge 64 commits intozephyrproject-rtos:mainfrom
cvinayak wants to merge 64 commits intozephyrproject-rtos:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR consolidates Bluetooth Controller changes for CI validation, implementing significant enhancements to the Bluetooth LE Controller subsystem. The changes focus on improving scheduling robustness, adding support for nRF54H20 SoC, refactoring configuration handling, and re-enabling previously disabled tests.
Changes:
- Renamed configuration files from device-specific to generic naming convention (e.g.,
nrf5340_cpunet_iso-bt_ll_sw_split.conf→extra-iso-bt_ll_sw_split.conf) - Implemented ticker oust_expire mechanism and slot window jitter support for better handling of preempted periodic events
- Refactored LLL prepare pipeline from MFIFO to ordered linked list for improved scheduling
- Added comprehensive nRF54H20 SoC support including HAL abstractions and hardware definitions
- Re-enabled previously disabled audio tests and removed workarounds for fixed controller issues
Reviewed changes
Copilot reviewed 119 out of 120 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/bsim/bluetooth/*/sysbuild.cmake | Updated to use EXTRA_CONF_FILE with renamed configuration files |
| tests/bsim/bluetooth/audio/test_scripts/*.sh | Removed -start_offset parameters and re-enabled previously disabled tests |
| tests/bsim/bluetooth/audio/src/*.c | Added err_rx_cnt tracking and initialization of test stream fields |
| subsys/bluetooth/controller/ticker/* | Implemented oust_expire mechanism and slot window jitter support |
| subsys/bluetooth/controller/ll_sw/ull_sync_iso.c | Added slot window jitter support for ISO synchronized receiver |
| subsys/bluetooth/controller/ll_sw/ull_peripheral.c | Implemented latency_oust handling for supervision timeout near scenarios |
| subsys/bluetooth/controller/ll_sw/ull.c | Refactored prepare pipeline from MFIFO to ordered linked list |
| subsys/bluetooth/controller/ll_sw/nordic/lll/* | Updated is_abort_cb signatures and improved prepare/abort handling |
| subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/* | Added comprehensive nRF54H20 SoC support |
| subsys/bluetooth/controller/Kconfig.ll_sw_split | Added configuration options for new features and nRF54H20 support |
| samples/bluetooth/*/sysbuild.cmake | Updated configuration file references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 120 out of 121 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cvinayak
force-pushed
the
github_bt_ctlr_next
branch
2 times, most recently
from
eaa1e04 to
a5c9339
Compare
cvinayak
force-pushed
the
github_bt_ctlr_next
branch
3 times, most recently
from
794f3fa to
4e046bc
Compare
cvinayak
force-pushed
the
github_bt_ctlr_next
branch
4 times, most recently
from
2b0787c to
37b6049
Compare
cvinayak
force-pushed
the
github_bt_ctlr_next
branch
6 times, most recently
from
9a03501 to
01fb097
Compare
cvinayak
force-pushed
the
github_bt_ctlr_next
branch
4 times, most recently
from
c5cc2be to
bb62bb9
Compare
cvinayak
force-pushed
the
github_bt_ctlr_next
branch
4 times, most recently
from
d3fdf8e to
6b35853
Compare
Improve ACL connection establishment by setting force flag during the first 6 connection intervals when failing reception or being preempted in the LLL prepare pipeline. Relates to commit cadef5a ("Bluetooth: Controller: Introduce BT_CTLR_PERIPHERAL_RESERVE_MAX"). Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Improve Periodic Sync robustness. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Improve ISO Receiver robustness. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Enable tests that pass now and respective github issues can be closed. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Fix ISO Receiver Sync Lost assertion due to successive calls to stop ticker instance under conditions where there are more than one ISO Sync LLL events enqueued in the LLL prepare pipeline. This is visible when supporting LLL resume for ISO Sync LLL events. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Added implementation to have ISO Sync Receiver resume ticker to reserve time for next BIS when using sequential packing. This is required so that any overlapping role that can drift in its window be place after the next BIS subevent. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Fix LL BIS simulation time as the tests implementation and simulation time were inconsistent. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Ticker Oust Expire feature. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Update Peripheral role to use Ticker Oust Expire feature. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Update Periodic Sync to use Ticker Oust Expire feature. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Update ISO Receiver to use Ticker Oust Expire feature. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Update Peripheral role to avoid defer lock step that can cause supervision timeout. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Add CPU overhead measurement to in-system profiling. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Replace prepare pipeline with ordered linked list. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Updated in-system profiling for CPU usage with on target measurements and added assertion checks. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
nrf54h20 cpurad bt_ll_sw_split support. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
FICR compile error fixed ECB compile error fixed SWI compile error fixed draft modification for radio Update radio.c due to miss some device check Signed-off-by: Jui-Chou Chung <jui-chou.chung@nordicsemi.no> Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Added initial implementation for nrf54hx LF clock control. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Added initial implementation for nrf54hx GRTC use for Radio. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Added initial implementation for nrf54hx HF clock control. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Added initial implementation for nrf54hx MRAM no latency control. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Added implementation to mitigate nrf54hx MRAM no latency control race. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
nRF54H20 cpuapp peripheral_hr quirks. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
nRF54H20 cpuapp hci_usb quirks. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
nRF54H20 cpurad hci_ipc quirks for ISO support Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
nRF54H20 cpurad hci_usb quirks for ISO support Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
bap broadcast source/sink nRF54H20DK with USB Audio Device support. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Review rework updates. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
force-pushed
the
github_bt_ctlr_next
branch
from
375e5c2 to
ad9e581
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bluetooth Controller consolidated next changes for CI validation.