Bluetooth: TBS: clear pending GTBS notifications on disconnect#104660
Open
Maxzuru wants to merge 1 commit intozephyrproject-rtos:mainfrom
Open
Bluetooth: TBS: clear pending GTBS notifications on disconnect#104660Maxzuru wants to merge 1 commit intozephyrproject-rtos:mainfrom
Maxzuru wants to merge 1 commit intozephyrproject-rtos:mainfrom
Conversation
zephyrbot
requested review from
Thalley,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
niym-ot and
sjanc
Contributor
Author
|
Not sure if this line needs to be in the loop in the first place: I would assume it could be at the top and used for both clearing blocks. |
Thalley
reviewed
Feb 27, 2026
Contributor
Thalley
left a comment
Thalley
left a comment
There was a problem hiding this comment.
No changes are absolutely needed, but would suggest these to be done
Maxzuru
force-pushed
the
gtbs_clear_notifications
branch
from
1a80072 to
a1366eb
Compare
Thalley
previously approved these changes
Feb 27, 2026
Comment on lines
381
to
383
| err = k_mutex_lock(>bs_inst.mutex, MUTEX_TIMEOUT); | ||
|
|
||
| if (err != 0) { |
Contributor
There was a problem hiding this comment.
Suggested change
| err = k_mutex_lock(>bs_inst.mutex, MUTEX_TIMEOUT); | |
| if (err != 0) { | |
| err = k_mutex_lock(>bs_inst.mutex, MUTEX_TIMEOUT); | |
| if (err != 0) { |
Minor
Add missing notification clearing for the GTBS instance in the disconnected callback. Fixes zephyrproject-rtos#104568 Signed-off-by: Maximilian Zimmermann <gitmz@posteo.de>
Maxzuru
force-pushed
the
gtbs_clear_notifications
branch
from
a1366eb to
359982c
Compare
|
Thalley
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing notification clearing for the GTBS instance in the disconnected callback.
Fixes #104568