Zephyr SDK 1.0.0-rc1 build fixes#104712
Open
keith-packard wants to merge 3 commits intozephyrproject-rtos:mainfrom
Open
Zephyr SDK 1.0.0-rc1 build fixes#104712keith-packard wants to merge 3 commits intozephyrproject-rtos:mainfrom
keith-packard wants to merge 3 commits intozephyrproject-rtos:mainfrom
Conversation
zephyrbot
added
area: UART
zephyrbot
requested review from
57300,
MaureenHelm,
dcpleung,
jeremybettis,
nashif,
nordicjm,
ozersa,
petejohanson-adi,
stephanosio,
tejlmand,
ttmut and
yasinustunerg
When UART_INTERRUPT_DRIVE, PM and UART_CONSOLE_INPUT_EXPIRED are all defined the driver uses the device flags without the necessary declaratoins or fetching the hardware register. Signed-off-by: Keith Packard <keithp@keithp.com>
This should prevent GCC from eliding these otherwise-unused asm statements. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
force-pushed
the
build-fixes
branch
from
9bbdb13 to
3d4116b
Compare
This object file is used to have the compiler compute various constants with the results being extracted with a python script. If LTO is used, none of those constants will end up in the resulting object file. Signed-off-by: Keith Packard <keithp@keithp.com>
keith-packard
force-pushed
the
build-fixes
branch
from
3d4116b to
71bd3ed
Compare
|
Contributor
|
I think a fix as in the third commit is already on main 2d747e5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm cleaning up various build problems with SDK 1.0.0 that have crept into the tree. Here are three fixes:
__volatile__, the compiler occasionally elides asm statements that have unused output parameters. I don't think that's true for these, but it's safest to always use__volatile__.