drivers: adc: stm32: suppress stm32h7 build warning#47173
Merged
carlescufi merged 1 commit intozephyrproject-rtos:mainfrom Jul 4, 2022
Merged
drivers: adc: stm32: suppress stm32h7 build warning#47173carlescufi merged 1 commit intozephyrproject-rtos:mainfrom
carlescufi merged 1 commit intozephyrproject-rtos:mainfrom
Conversation
There is a build warning of unused `adc_stm32_oversampling_ratioshift` function: [-Werror=unused-function]. This makes twister fail, as all warnings are treated as errors. Fix that by ifndef'ing adc_stm32_oversampling_ratioshift(). Fixes: c57a41c ("drivers/adc: stm32: do not disable the ADC if resolution is unchanged") Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
zephyrbot
added
platform: STM32
Member
Author
aurel32
approved these changes
Jul 1, 2022
Contributor
aurel32
left a comment
aurel32
left a comment
There was a problem hiding this comment.
First of all sorry for introducing this issue. Your fix looks good, thanks. An alternative fix is to declare the function inline.
bbilas
approved these changes
Jul 1, 2022
erwango
approved these changes
Jul 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a build warning of unused
adc_stm32_oversampling_ratioshiftfunction:
[-Werror=unused-function]. This makes twister fail, as allwarnings are treated as errors.
Fix that by ifndef'ing
adc_stm32_oversampling_ratioshift().Fixes: c57a41c ("drivers/adc: stm32: do not disable the ADC if
resolution is unchanged")