tests: bluetooth: host: Fix CI failures with bt_keys_get_addr() UT#51293
Merged
carlescufi merged 1 commit intozephyrproject-rtos:mainfrom Oct 14, 2022
Conversation
CI tests were failing due to a recent change to zassume_true() implementation. While the test case is still skipped when assumption fails, but it is now causing the final execution result to fail. zassume_true() was replaced by ztest_test_skip() combined with a conditional 'if' statement to get the required effect. Signed-off-by: Ahmed Moheb <ahmed.moheb@nordicsemi.no>
ahmedmoheb-nordic
requested review from
Vudentz,
alwa-nordic,
jhedberg and
sjanc
as code owners
zephyrbot
requested review from
Thalley,
asbjornsabo,
hermabe and
jori-nordic
Contributor
|
@sem1-nordic @ppryga-nordic fyi |
jori-nordic
approved these changes
Oct 14, 2022
ppryga-nordic
approved these changes
Oct 14, 2022
alwa-nordic
approved these changes
Oct 14, 2022
ahmedmoheb-nordic
deleted the
fix_ci_failures_with_bt_keys_get_addr_unit_test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI tests were failing due to a recent change to zassume_true() implementation.
While the test case is still skipped when assumption fails, but it is now causing the final execution result to fail.
zassume_true() was replaced by ztest_test_skip() combined with a conditional 'if' statement to get the required effect.
Signed-off-by: Ahmed Moheb ahmed.moheb@nordicsemi.no