Add software blinking to GPIO LEDs#57791
Add software blinking to GPIO LEDs#57791blemouzy wants to merge 2 commits intozephyrproject-rtos:mainfrom
Conversation
|
Comments are welcomed:
|
f901ac5 to
399eefb
Compare
simonguinot
left a comment
There was a problem hiding this comment.
Hi @blemouzy,
Thanks for this PR but I can't agree with this.
The plan for software LED blinking is to implement a fallback at the LED core level. This way it will be available for ALL the LED drivers and not only led_gpio.
If a driver implements the blink API function (because the feature is supported by hardware) then it can be used directly else we can fall back on a software blinking mechanism (based on timer and/or workqueue).
For reference see the following discussions:
- #54594 (comment)
- #50511 (for color correction but the idea is the same)
Add blink command to led shell. Signed-off-by: Benjamin Lemouzy <blemouzy@centralp.fr>
Add new CONFIG_LED_GPIO_BLINK to add GPIO LEDs software blinking. Signed-off-by: Benjamin Lemouzy <blemouzy@centralp.fr>
399eefb to
c81e21b
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
blinkcommand to led shell