Skip to content

Implement voltage biasing for ADS114s08#65934

Merged
nashif merged 1 commit intozephyrproject-rtos:mainfrom
benediktibk:add_vbias_ads114s08
Mar 11, 2024
Merged

Implement voltage biasing for ADS114s08#65934
nashif merged 1 commit intozephyrproject-rtos:mainfrom
benediktibk:add_vbias_ads114s08

Conversation

@benediktibk
Copy link
Contributor

Implement voltage biasing on the inputs of the ADC ADS114s08.

@benediktibk benediktibk force-pushed the add_vbias_ads114s08 branch 3 times, most recently from 10ebcb3 to 089d7dd Compare November 29, 2023 16:27
@benediktibk benediktibk marked this pull request as ready for review November 29, 2023 16:31
@zephyrbot zephyrbot added platform: TI SimpleLink Texas Instruments SimpleLink MCU area: Devicetree Binding PR modifies or adds a Device Tree binding area: ADC Analog-to-Digital Converter (ADC) labels Nov 29, 2023
@benediktibk
Copy link
Contributor Author

rebased to resolve merge conflicts

@benediktibk
Copy link
Contributor Author

@anangl Could you please take a look at this PR?

@benediktibk benediktibk added the dev-review To be discussed in dev-review meeting label Jan 15, 2024
@benediktibk benediktibk added this to the v3.6.0 milestone Jan 24, 2024
@MaureenHelm MaureenHelm removed the dev-review To be discussed in dev-review meeting label Jan 25, 2024
@MaureenHelm
Copy link
Member

@anangl please take a look

@henrikbrixandersen henrikbrixandersen removed this from the v3.6.0 milestone Feb 7, 2024
@benediktibk benediktibk requested a review from decsny February 22, 2024 16:11
@decsny
Copy link
Member

decsny commented Feb 22, 2024

@MaureenHelm what do we do here if assignee and maintainer is not engaging

@benediktibk benediktibk force-pushed the add_vbias_ads114s08 branch from 45154a7 to 7bfbbeb Compare March 4, 2024 06:58
@benediktibk benediktibk requested a review from GeorgeCGV March 4, 2024 08:23
@benediktibk benediktibk force-pushed the add_vbias_ads114s08 branch 2 times, most recently from 272b396 to 461a9c3 Compare March 4, 2024 21:12
@benediktibk benediktibk force-pushed the add_vbias_ads114s08 branch from 461a9c3 to 083579f Compare March 4, 2024 22:22
decsny
decsny previously approved these changes Mar 4, 2024
Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@henrikbrixandersen
Copy link
Member

@MaureenHelm what do we do here if assignee and maintainer is not engaging

We have a clear escalation path for this, documented here: https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-review-escalation

Implement voltage biasing on the inputs of the ADC ADS114s08.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
@benediktibk benediktibk force-pushed the add_vbias_ads114s08 branch from ff812c2 to 634193a Compare March 11, 2024 16:18
@benediktibk benediktibk requested a review from decsny March 11, 2024 16:31
@nashif nashif merged commit b47c66e into zephyrproject-rtos:main Mar 11, 2024
@benediktibk benediktibk deleted the add_vbias_ads114s08 branch March 12, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ADC Analog-to-Digital Converter (ADC) area: Devicetree Binding PR modifies or adds a Device Tree binding platform: TI SimpleLink Texas Instruments SimpleLink MCU

9 participants