Support NXP ENET_1G gigabit ethernet on mimxrt1170_evk#69207
Merged
nashif merged 9 commits intozephyrproject-rtos:mainfrom Jun 7, 2024
Merged
Conversation
stanislav-poboril
requested review from
dleach02,
jukkar,
mmahadevan108,
rlubos and
tbursztyka
as code owners
zephyrbot
added
area: Devicetree Binding
stanislav-poboril
removed
area: Networking
area: Samples
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
danieldegrasse,
dbaluta,
decsny,
galak,
manuargue,
nordic-krch,
ssharks and
yvanderv
decsny
previously approved these changes
Jun 5, 2024
Member
decsny
left a comment
decsny
left a comment
There was a problem hiding this comment.
thanks for the patience on this PR @stanislav-poboril
Contributor
Author
|
Pushed additional updates for vmu_rt1170 after it has been reconfigured to use TJA1103 ethernet PHY. @bperseghetti, would it be possible to verify again if ethernet works on vmu_rt1170? Thank you. |
Member
|
this compliance fail I've seen on a few PRs now where it doesn't seem related to the PR |
Member
|
#73403 has a fix for the compliance issue |
dleach02
previously approved these changes
Jun 5, 2024
pdgendt
previously approved these changes
Jun 6, 2024
stanislav-poboril
force-pushed
the
66348_nxp_enet_rt11xx_enet1g_support
branch
from
6e523b9 to
a71ad9f
Compare
Contributor
Author
Rebased to take it. |
stanislav-poboril
force-pushed
the
66348_nxp_enet_rt11xx_enet1g_support
branch
from
a71ad9f to
a4a6e42
Compare
pdgendt
reviewed
Jun 6, 2024
stanislav-poboril
dismissed stale reviews from decsny, dleach02, and pdgendt
via
224f540
stanislav-poboril
force-pushed
the
66348_nxp_enet_rt11xx_enet1g_support
branch
from
a4a6e42 to
224f540
Compare
pdgendt
approved these changes
Jun 6, 2024
Add ENET_1G clock value to the RT11XX CCM version. Implemented enabling ENET_1G clock and getting its frequency. Signed-off-by: Stanislav Poboril <stanislav.poboril@nxp.com>
Support NXP ENET_1G on RT11xx soc. Fixes: zephyrproject-rtos#66348 Signed-off-by: Stanislav Poboril <stanislav.poboril@nxp.com>
Add option for RGMII connection type between the MAC and the PHY device into the ethernet controller binding. Fixes: zephyrproject-rtos#66348 Signed-off-by: Stanislav Poboril <stanislav.poboril@nxp.com>
Add RGMII mode definition to be used in bindings related to NXP ENET_1G IP. Fixes: zephyrproject-rtos#66348 Signed-off-by: Stanislav Poboril <stanislav.poboril@nxp.com>
- Added nxp,enet1g compatible to distinguish between ENET (nxp,enet) and ENET_1G (nxp,enet1g) peripherals within the same driver. - Added config ETH_NXP_ENET_1G to enable 1G mode of operation on ENET_1G. - Support RGMII mode of connection between MDIO and PHY to be able to work with ENET_1G peripheral and support 1000M speed. - Removed performing of PHY reset before configuring link - it is not desirable for RTL8211F PHY connected to ENET_1G on RT1170. Reset of other PHYs can be performed by PHY driver itself if required. Fixes: zephyrproject-rtos#66348 Signed-off-by: Stanislav Poboril <stanislav.poboril@nxp.com>
Add a kconfig preprocessor function to check if any node of a certain compatible has a specific property in DT. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add driver for Realtek RTL8211F 10/100/1000M ethernet PHY. This driver implements vendor specific behaviour like detecting link state change by GPIO interrupt, which is not present in the generic MII driver. Fixes: zephyrproject-rtos#66348 Signed-off-by: Stanislav Poboril <stanislav.poboril@nxp.com>
Support NXP ENET_1G on mimxrt1170_evk/mimxrt1176/cm7 platform. Added test configuration sample.net.zperf.nxp_enet1g and documented the usage of the ethernet driver with ENET_1G peripheral. Fixes: zephyrproject-rtos#66348 Signed-off-by: Stanislav Poboril <stanislav.poboril@nxp.com>
Adjusted the board's device tree after ENET_1G compatible changed from "nxp,kinetis-ethernet" to "nxp,enet1g". Signed-off-by: Stanislav Poboril <stanislav.poboril@nxp.com>
stanislav-poboril
force-pushed
the
66348_nxp_enet_rt11xx_enet1g_support
branch
from
224f540 to
dec5a14
Compare
dleach02
approved these changes
Jun 6, 2024
decsny
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #66348 on mimxrt1170_evk board.
Along with this change, the Microchip KSZ8081 PHY driver needed to be updated a little, so the eth_nxp_enet can work with both PHYs. Also fixed few issues found in that PHY driver when doing the changes.