scripts: Allow certificate binary files in networking samples#70817
scripts: Allow certificate binary files in networking samples#70817jukkar wants to merge 1 commit intozephyrproject-rtos:mainfrom
Conversation
The samples could have certificate files (with .der suffix) like for example in networking samples. Allow these binary files in the samples/net directory. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
zephyrbot
added
area: Coding Guidelines
zephyrbot
requested review from
carlescufi,
fabiobaltieri,
jfischer-no,
kartben,
keith-zephyr,
nashif and
stephanosio
|
This is related to compliance issue in #63531 which adds a new sample with binary certificates. |
jukkar
added
the
Trivial
|
Hey @jukkar do you expect these to change often or to need more? I'm wondering if it would not be a better idea to bypass compliance for this one on the specific pull request if you expect it to be a one-off. Been reading about the recent xz backdoor story and I'm thinking it may be a good idea to keep binary files in samples manually vetted, now that I look at it even the current list freaks me out a bit. |
Very good point. Another option might be to document and explain to the user how they can generate their own certificate? |
At least for now, this would be one-off and we could handle it case by case. I do not mind if we have to manually override the check in the future. Feel free to close this one if you think it makes more sense that way. |
fabiobaltieri
left a comment
fabiobaltieri
left a comment
There was a problem hiding this comment.
At least for now, this would be one-off and we could handle it case by case. I do not mind if we have to manually override the check in the future. Feel free to close this one if you think it makes more sense that way.
I think we may take that way for now, we can always revisit if it gets in the way again. I'll put a block on this while the others take a look as well.
|
Also #64465 will need force merge as it will contain a sample with certificates. |
|
Binary test files are cool, one can hide easter eggs in them. |
|
Dependent PR has been merged, closing this down, thanks for your understanding Jukka. |
7 participants
The samples could have certificate files (with .der suffix) like for example in networking samples. Allow these binary files in the samples/net directory.