nrf54h20: Fix EXMIF build failures#73295
Closed
krish2718 wants to merge 3 commits intozephyrproject-rtos:mainfrom
Closed
nrf54h20: Fix EXMIF build failures#73295krish2718 wants to merge 3 commits intozephyrproject-rtos:mainfrom
krish2718 wants to merge 3 commits intozephyrproject-rtos:mainfrom
Conversation
JordanYates
previously approved these changes
May 25, 2024
Contributor
|
Pulled both of these revert commits into #73302, which fixes both issues with the sample in one PR, letting CI pass. |
e-rk
approved these changes
May 27, 2024
anangl
previously approved these changes
May 27, 2024
This reverts commit 064d8d8. This causes build failure, EXMIF support for nRF54H20DK needs mor work. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
This reverts commit b1de9a6. This causes build failure, EXMIF support for nRF54H20DK needs more work. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Add the necessary alias for SPI flash sample to fix the build error. The sample auto-chooses the device based on DT compatible property, so, having the alias mandatory. Fixes commit c8faa1e("boards: st: Add support for STM32H745I-Disco"). Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
ajarmouni-st,
erwango and
gautierg-st
FRASTM
reviewed
Jun 5, 2024
| led0 = &green_led; | ||
| pwm-led0 = &green_pwm_led; | ||
| sw0 = &user_button; | ||
| spi-flash0 = &mt25ql512ab1; |
Contributor
Author
|
Closing PR as all fixes are part of other PRs linked above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build failure started with this fa86c51