jlink: custom flashing support

[jcpi-q]

Allows to use a custom flashing script with jlink runners.

[github-actions]

Hello @jcpi-q, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

[pdgendt]

Requires a rebase

[kartben]

@jcpi-q can you please rebase as there is a merge conflict now? Thanks!

[github-actions]

Hi @jcpi-q!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

[zeonchew]

Hi @jcpi-q

Would like to check with you whether it is intended that after refactoring into run_flash_cmd(), that the construction of cmd variable goes into the condition if self.supports_loader and self.loader: instead of staying outside of the if statement as it was?

zephyr/scripts/west_commands/runners/jlink.py

Lines 413 to 438 in f90ce01

	def run_flash_cmd(self, fname, flash_file, **kwargs):
	loader_details = ""
	if self.supports_loader and self.loader:
	loader_details = "?" + self.loader
	cmd = (
	[self.commander]
	+ (
	['-IP', f'{self.dev_id}']
	if (is_ip(self.dev_id) or is_tunnel(self.dev_id))
	else (['-USB', f'{self.dev_id}'] if self.dev_id else [])
	)
	+ (['-nogui', '1'] if self.supports_nogui else [])
	+ ['-if', self.iface]
	+ ['-speed', self.speed]
	+ ['-device', self.device + loader_details]
	+ ['-CommanderScript', fname]
	+ (['-nogui', '1'] if self.supports_nogui else [])
	+ self.tool_opt
	)
	if flash_file:
	self.logger.info(f'Flashing file: {flash_file}')
	kwargs = {}
	if not self.logger.isEnabledFor(logging.DEBUG):
	kwargs['stdout'] = subprocess.DEVNULL
	self.check_call(cmd, **kwargs)

west flash command stops to works at my side because variable cmd is not initialized, as the loader option is not used.
Hence causing exception to the thrown at the execution line at L438:

zephyr/scripts/west_commands/runners/jlink.py

Line 438 in f90ce01

self.check_call(cmd, **kwargs)

[kartben]

Hi @jcpi-q

Would like to check with you whether it is intended that after refactoring into run_flash_cmd(), that the construction of cmd variable goes into the condition if self.supports_loader and self.loader: instead of staying outside of the if statement as it was?

zephyr/scripts/west_commands/runners/jlink.py

Lines 413 to 438 in f90ce01

	def run_flash_cmd(self, fname, flash_file, **kwargs):
	loader_details = ""
	if self.supports_loader and self.loader:
	loader_details = "?" + self.loader
	cmd = (
	[self.commander]
	+ (
	['-IP', f'{self.dev_id}']
	if (is_ip(self.dev_id) or is_tunnel(self.dev_id))
	else (['-USB', f'{self.dev_id}'] if self.dev_id else [])
	)
	+ (['-nogui', '1'] if self.supports_nogui else [])
	+ ['-if', self.iface]
	+ ['-speed', self.speed]
	+ ['-device', self.device + loader_details]
	+ ['-CommanderScript', fname]
	+ (['-nogui', '1'] if self.supports_nogui else [])
	+ self.tool_opt
	)
	if flash_file:
	self.logger.info(f'Flashing file: {flash_file}')
	kwargs = {}
	if not self.logger.isEnabledFor(logging.DEBUG):
	kwargs['stdout'] = subprocess.DEVNULL
	self.check_call(cmd, **kwargs)

west flash command stops to works at my side because variable cmd is not initialized, as the loader option is not used.
Hence causing exception to the thrown at the execution line at L438:

zephyr/scripts/west_commands/runners/jlink.py

Line 438 in f90ce01

self.check_call(cmd, **kwargs)

#82005

@jcpi-q @pdgendt can you help line up a (hot)fix please? Or we can just revert for now.