Skip to content

ethernet: stm32_hal: Allow to configure preemtiveness independent of tc#87116

Merged
kartben merged 1 commit intomainfrom
unknown repository
Mar 18, 2025
Merged

ethernet: stm32_hal: Allow to configure preemtiveness independent of tc#87116
kartben merged 1 commit intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Mar 14, 2025

Allow to configure the preemtiveness of the ethernet rx-thread independent of the traffic-class queue.

Fixes: #87094

Allow to configure the preemtiveness of the ethernet rx-thread independent
of the traffic-class queue.

Signed-off-by: Cla Mattia Galliard <cla-mattia.galliard@zuehlke.com>
Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i specifically remember saying to do this on the original PR, dont know why it wasnt done then

@ghost
Copy link
Author

ghost commented Mar 18, 2025

i specifically remember saying to do this on the original PR, dont know why it wasnt done then

Yes, I mentioned it in the linked issue.

@ghost
Copy link
Author

ghost commented Mar 18, 2025

#77904 caused a performance regression due to the implicit change of priority of the rx-thread (The default behavior was changed in that PR).

@ghost
Copy link
Author

ghost commented Mar 18, 2025

This PR proposes to preserve the 4.1 default behavior (tracking the tc-thread cooperativeness) instead of the 4.0 behavior of the rx-thread being cooperative. It is debatable which default behavior is better.

@kartben kartben merged commit 59b02d1 into zephyrproject-rtos:main Mar 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

7 participants