Skip to content

drivers: video: Migrate ov7670 and smartdma to use video interfaces binding#88323

Merged
nashif merged 4 commits intozephyrproject-rtos:mainfrom
nxp-upstream:ov7670_sdma_migration
Apr 26, 2025
Merged

drivers: video: Migrate ov7670 and smartdma to use video interfaces binding#88323
nashif merged 4 commits intozephyrproject-rtos:mainfrom
nxp-upstream:ov7670_sdma_migration

Conversation

@ngphibang
Copy link
Contributor

@ngphibang ngphibang commented Apr 8, 2025 •
edited
Loading

This PR
@github-actions github-actions bot added platform: NXP NXP area: Samples Samples platform: NXP Drivers NXP Semiconductors, drivers area: Video Video subsystem labels Apr 8, 2025
This was linked to issues Apr 8, 2025
Some video drivers lack of CI tests #85178
Closed
meta: Track progress on moving video drivers and devicetree to use the video-interfaces binding and the endpoint DT macros #80514
Open
josuah
josuah previously approved these changes Apr 9, 2025
View reviewed changes
@josuah josuah mentioned this pull request Apr 9, 2025
Open
@ngphibang ngphibang mentioned this pull request Apr 17, 2025
Merged
@dleach02
Copy link
Member

dleach02 commented Apr 21, 2025

@ngphibang is there a particular sequence of PRs we should be working to merge here?
@ngphibang
Copy link
Contributor Author

ngphibang commented Apr 21, 2025 •
edited
Loading

@dleach02 : No dependency, but I would like to have #82158 get merged first to avoid unnecessary conflict to resolve on that PR.
@ngphibang ngphibang force-pushed the ov7670_sdma_migration branch from 0633a5f to 0c36711 Compare April 21, 2025 19:29
@dleach02
Copy link
Member

dleach02 commented Apr 23, 2025

#82158 merged... resolve the merge conflict and we can likely get this merged soon
@ngphibang ngphibang force-pushed the ov7670_sdma_migration branch from 0c36711 to 2d3a98d Compare April 23, 2025 09:46
@ngphibang ngphibang force-pushed the ov7670_sdma_migration branch from 2d3a98d to 513b0dc Compare April 23, 2025 10:06
@ngphibang
Copy link
Contributor Author

ngphibang commented Apr 23, 2025

Just a simple rebase as #88890 was merged yesterday.
@ngphibang ngphibang force-pushed the ov7670_sdma_migration branch from 513b0dc to 4fbe7d1 Compare April 23, 2025 12:28
@josuah josuah self-requested a review April 23, 2025 13:16
@ngphibang ngphibang mentioned this pull request Apr 23, 2025
Merged
@ngphibang
drivers: video: smartdma: Fix a typo breaking the build
f0bc217 
Fix a typo so that it won't break the build.

Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
@ngphibang
drivers: video: Use video interfaces binding for ov7670 and smartdma
8ee0836 
Have ov7670 and video smartdma use video interfaces binding. With
this, we can fix the chicken-egg issue in init priority and don't need
the workaround anymore.

Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
@ngphibang ngphibang force-pushed the ov7670_sdma_migration branch from 4fbe7d1 to 72394c7 Compare April 23, 2025 15:04
@ngphibang
Copy link
Contributor Author

ngphibang commented Apr 24, 2025

@josuah @dleach02 Could you revisit (there's now a typo fix affecting the smartdcma driver build #88890 (comment)) ?
josuah
josuah reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you confirm that tests/drivers/build_all/video/frdm_mcxn947_mcxn947_cpu0.overlay is being used by twister? I have the impression it is not selected.

The rest is minor bikeshedding.

Thank you for the bugfixes and adding more boards to twister!
@ngphibang
tests: drivers: build_all: video: Add test case for smartdma
ef44619 
Add built-only test case for smartdma driver

Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
@ngphibang
tests: drivers: build_all: video: Move board-specific overlays to boards
9603a8c 
Move board-specific overlays to boards folder

Signed-off-by: Phi Bang Nguyen <phibang.nguyen@nxp.com>
@ngphibang ngphibang force-pushed the ov7670_sdma_migration branch from 72394c7 to 9603a8c Compare April 24, 2025 11:56
@ngphibang
Copy link
Contributor Author

ngphibang commented Apr 24, 2025 •
edited
Loading

Could you confirm that tests/drivers/build_all/video/frdm_mcxn947_mcxn947_cpu0.overlay is being used by twister? I have the impression it is not selected.

It is selected and used by twister. You can try something wrong in the overlay and run:

west twister -i -T tests/drivers/build_all/video

or (to save time):

west build -p -b frdm_mcxn947/mcxn947/cpu0 tests/drivers/build_all/video -T drivers.video.mcux_smartdma.build

You will see it complains. It took me some time to make it pass CI correctly :-)
josuah
josuah approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

[EDIT: that helped a lot getting UVC working on FRDM-MCXN947! UVC support might come for it as soon as the UVC PR is merged]
@dleach02 dleach02 closed this Apr 25, 2025
@dleach02 dleach02 reopened this Apr 25, 2025
@dleach02
Copy link
Member

dleach02 commented Apr 25, 2025

closed/open to rekick CI
This was referenced Apr 26, 2025
Merged
Merged
@nashif nashif merged commit cf6f9e3 into zephyrproject-rtos:main Apr 26, 2025
31 checks passed
@ngphibang ngphibang deleted the ov7670_sdma_migration branch June 24, 2025 15:57
@ngphibang ngphibang mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Samples Samples area: Video Video subsystem platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP

5 participants

@ngphibang @dleach02 @josuah @nashif @mmahadevan108