drivers: video: CONFIG_VIDEO_SW_GENERATOR -> zephyr,video-sw-generator#88780
Merged
kartben merged 6 commits intozephyrproject-rtos:mainfrom Jun 2, 2025
Merged
Conversation
github-actions
bot
added
area: Video
github-actions
bot
requested review from
57300,
decsny,
galak,
jeremybettis,
kartben,
loicpoulain,
nashif,
ngphibang,
nordicjm,
rruuaanng and
tejlmand
This was referenced Apr 18, 2025
Contributor
Author
josuah
force-pushed
the
pr-video-sw-generator-dt
branch
from
f62e2d4 to
8bd2a1d
Compare
loicpoulain
previously approved these changes
Apr 18, 2025
Contributor
loicpoulain
left a comment
loicpoulain
left a comment
There was a problem hiding this comment.
LGTM, but not tested.
ngphibang
reviewed
Apr 18, 2025
Comment on lines
10
to
12
| child-binding: | ||
| child-binding: | ||
| include: video-interfaces.yaml |
Contributor
There was a problem hiding this comment.
No need to add this because you don't have child node and use nothing from video-interfaces binding.
Contributor
Author
There was a problem hiding this comment.
Good point, no "sub-devices"... It is the "head" of the pipeline on its own.
Contributor
There was a problem hiding this comment.
It seems you forgot to remove these ?
Contributor
Author
There was a problem hiding this comment.
Right thank you! I thought I needed to use it for the video_sw_pipeline but it ended-up not the case, I simply did not know how to best handle "m2m" devices. removed now!
Contributor
|
It's fine to me to turn video sw generator into devicetree so that #76798 can get merged because it's been there for a long time. For a long-term solution, as discussed in #88182 and in #76798, I think
But we can do that later as a future extension (as currently, we are all based on zephyr,camera) to not postpone #76798. |
josuah
force-pushed
the
pr-video-sw-generator-dt
branch
2 times, most recently
from
ec0c215 to
cb21eb8
Compare
Contributor
Author
|
force-push:
Thank you all for your patience! |
josuah
force-pushed
the
pr-video-sw-generator-dt
branch
from
8ae099c to
e5127bc
Compare
Contributor
Author
|
Thanks for the review @avolmat-st! Though I just applied @JarmouniA diff saying |
JarmouniA
previously approved these changes
May 19, 2025
avolmat-st
requested changes
May 19, 2025
josuah
force-pushed
the
pr-video-sw-generator-dt
branch
from
e5127bc to
5dcb0e3
Compare
JarmouniA
previously approved these changes
May 20, 2025
avolmat-st
previously approved these changes
May 20, 2025
josuah
force-pushed
the
pr-video-sw-generator-dt
branch
2 times, most recently
from
f57f701 to
0aca1b4
Compare
By having an "auto-fallback" mechanism, the VIDEO_SW_GENERATOR did shadow the fact that "platform:mimxrt1064_evk:SHIELD=dvp_fpc24_mt9m114" was missing the full specification, and therefore was not matched at all: the shield was not selected, but the CI still worked. Signed-off-by: Josuah Demangeon <me@josuah.net>
Make the video software generator a devicetree node, which allows enabling
several instances, and select it as chosen { zephyr,camera = &... }; node.
It can be enabled via a `video-sw-generator` snippet.
Signed-off-by: Josuah Demangeon <me@josuah.net>
Convert the log module declarationto the new syntax introduced in 5e34681 proposing a more compact syntax. This fixes the log level not being updated in the "capture" sample. Signed-off-by: Josuah Demangeon <me@josuah.net>
Since this sample's headers are now grouped it is possible to sort them alphabetically. Signed-off-by: Josuah Demangeon <me@josuah.net>
Variables that holds pointers to 'const struct device' typically end-up with '_dev'. The tcpserversink video sample did not have it. Add it. Signed-off-by: Josuah Demangeon <me@josuah.net>
The zephyr,camera was used in several samples, but was not documented. Add the missing documentation entry for it in the list. Signed-off-by: Josuah Demangeon <me@josuah.net>
josuah
force-pushed
the
pr-video-sw-generator-dt
branch
from
0aca1b4 to
d845bd2
Compare
Contributor
Author
|
Force-push:
One more review round to go... Thanks all for your patience! |
|
ngphibang
approved these changes
Jun 1, 2025
avolmat-st
approved these changes
Jun 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream:
Related:
As pointed out in the UVC PR, the typical way to configure hardware-like devices in Zephyr is via a chosen node. The other proposed approach for default video devices is #88182.
Because this is a purely virtual hardware, a snippet is provided to enable it in any example via
--snippet video-sw-generator. Document its use in the 3 capture samplesREADME.rst. Thezephyr,cameradoc was missing and is also added.If this is indeed the way to go, I will convert these other PRs to use the devicetree instead of Kconfig: