Bluetooth: Controller: Add code comments related to short prepare#97863
Merged
kartben merged 1 commit intozephyrproject-rtos:mainfrom Oct 23, 2025
Merged
Conversation
Add code comments explaining the handling of short prepare that can be enqueued out of order and present in use of FIFO for prepare pipeline. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
|
zephyrbot
requested review from
Tronil,
carlescufi,
erbr-ot,
ppryga,
thoh-ot and
wopu-ot
cvinayak
added
the
Trivial
cvinayak
commented
Oct 20, 2025
carlescufi
approved these changes
Oct 23, 2025
aescolar
reviewed
Oct 23, 2025
| * timeout, refer to `preempt_ticker_start()` for details. | ||
| * | ||
| * We also set the `ready` to NULL as it is the same ready, the one | ||
| * being enqueued. This help short circuit a related assertion check |
Member
There was a problem hiding this comment.
Suggested change
| * being enqueued. This help short circuit a related assertion check | |
| * being enqueued. This helps short circuit a related assertion check |
| * being enqueued. This help short circuit a related assertion check | ||
| * later in this function. | ||
| */ | ||
| ready = NULL; |
Member
There was a problem hiding this comment.
This would not be just a comment then :)
aescolar
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add code comments explaining the handling of short prepare that can be enqueued out of order and present in use of FIFO for prepare pipeline.