boards: shields: add mchp_rnbd451_bt by JamesLiu-Microchip · Pull Request #98043 · zephyrproject-rtos/zephyr

JamesLiu-Microchip · 2025-10-22T05:53:55Z

Add board support for the Microchip RNBD451 shield. This shield is compatible with a development board that includes a mikroBUS socket. This shield is intended to enable Bluetooth Low Energy functionality.

github-actions · 2025-10-22T05:54:47Z

Hello @JamesLiu-Microchip, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

NhMchp · 2025-10-22T06:56:29Z

@JamesLiu-Microchip , fix compliance issues

boards/shields/mchp_rnbd451_bt/mchp_rnbd451_bt.overlay

boards/shields/mchp_rnbd451_bt/boards/sam_e54_xpro.overlay

sonarqubecloud · 2025-11-10T07:30:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

boards/shields/mchp_rnbd451_bt/doc/index.rst

kartben · 2025-11-10T21:51:01Z

boards/shields/mchp_rnbd451_bt/doc/index.rst

+Navigate to the project root directory. For example, if the Zephyr workspace was setup
+following the Application Development section in the Zephyr Project Documentation,
+use the following command.
+
+``cd zephyrproject``
+
+Append the above mentioned ``prj.conf`` configurations to each ``prj.conf`` in Example #1~#5.
+Build the applications located in ``zephyr/samples/bluetooth`` using the following commands:
+
+----+---------------------+------------------------------------------------------------------------------------------------------------+
+| No | Example name        | Build command                                                                                              |
+====+=====================+============================================================================================================+
+| 1  | Peripheral          | west build -p always -b sam_e54_xpro --shield mchp_rnbd451_bt zephyr/samples/bluetooth/peripheral          |
+----+---------------------+------------------------------------------------------------------------------------------------------------+
+| 2  | HID Peripheral      | west build -p always -b sam_e54_xpro --shield mchp_rnbd451_bt zephyr/samples/bluetooth/peripheral_hids     |
+----+---------------------+------------------------------------------------------------------------------------------------------------+
+| 3  | Peripheral Identity | west build -p always -b sam_e54_xpro --shield mchp_rnbd451_bt zephyr/samples/bluetooth/peripheral_identity |
+----+---------------------+------------------------------------------------------------------------------------------------------------+
+| 4  | Central Multilink   | west build -p always -b sam_e54_xpro --shield mchp_rnbd451_bt zephyr/samples/bluetooth/central_multilink   |
+----+---------------------+------------------------------------------------------------------------------------------------------------+
+| 5  | Central/Gatt Write  | west build -p always -b sam_e54_xpro --shield mchp_rnbd451_bt zephyr/samples/bluetooth/central_gatt_write  |
+----+---------------------+------------------------------------------------------------------------------------------------------------+
+
+
+For more information on building the applications, refer to the `Building
+<https://docs.zephyrproject.org/latest/develop/west/build-flash-debug.html#building-west-build>`_
+section.
+
+Flash the Applications
+**********************
+To flash the built application, use the following command:
+
+``west flash``


Just give one example of building one sample application, for a given board. No need for more

See for example https://docs.zephyrproject.org/latest/boards/shields/adafruit_aht20/doc/index.html#programming

Hi @kartben , Document was revised according to your review. could you please help to confirm again? Thank you.

boards/shields/mchp_rnbd451_bt/doc/index.rst

nandojve

Hi @JamesLiu-Microchip ,

Thank you for the newer changes.

I found a few minor things, overall, LGTM!

Make sure you rebase before push.

@kartben ,

Is it possible to create vendor folder in shields ?
I see that it is starting to get a little messy for some vendors and I would like to avoid it.

boards/microchip/sam/sam_e54_xpro/sam_e54_xpro.dts

boards/shields/mchp_rnbd451_bt/Kconfig.defconfig

boards/shields/mchp_rnbd451_bt/mchp_rnbd451_bt.overlay

nandojve · 2025-12-18T17:18:51Z

needs rebase

nandojve · 2025-12-26T09:24:27Z

Hi @JamesLiu-Microchip ,
Needs rebase : )

nandojve

LGTM!

The PR need rebase to solve new conflicts.

@kartben , could you take another look?

nandojve · 2026-02-14T08:54:20Z

ping @kartben

boards/shields/mchp_rnbd451_bt/mchp_rnbd451_bt_mikrobus.overlay

boards/shields/mchp_rnbd451_bt/mchp_rnbd451_bt.overlay

JarmouniA · 2026-02-15T00:56:49Z

boards/microchip/sam/sam_e54_xpro/sam_e54_xpro-pinctrl.dtsi

 		};
 	};

+	sercom5_uart_default: sercom5_uart_default {


Suggested change

sercom5_uart_default: sercom5_uart_default {

sercom5_uart_default: sercom5-uart-default {

There are other pin control definitions in this file; I prefer to reserve underscores to keep the style consistent.

The style is wrong https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#node-name-requirements

Has committed the change. However, I only revised the node I added and preserved the original underscore style use by others.

This change makes twister-build fail because the "sercom1_uart_default" node is already defined in two overlay files in the tests/drivers/uart folder. The device tree compiler treats both as the same label and reports a duplicate definition. Do you have any suggestions?

Changing the definition in the tests/drivers/uart folder is not a good idea because it would alter definitions by other people and is not related to the original feature that was added.

It's just 2 instances. Fixing test issues is part of any PR.
https://github.com/search?q=repo%3Azephyrproject-rtos%2Fzephyr%20path%3A%2F%5Etests%5C%2F%2F%20sercom1_uart_default&type=code
If the nodes in the tests represent the same one in the board, just use the node phandle (&sercom1_uart_default {) in the test instead of redefining the node. If it's another node, give the test or board node a different node name.

dts/bindings/gpio/microchip,xpro-header.yaml

kartben · 2026-02-16T12:38:32Z

boards/shields/mchp_rnbd451_bt/doc/index.rst

+
+   **Figure 1: RNBD451 Add-on Board**


Suggested change

**Figure 1: RNBD451 Add-on Board**

Has committed the change.

kartben · 2026-02-16T12:38:38Z

boards/shields/mchp_rnbd451_bt/doc/index.rst

+
+   **Figure 2: ATMBUSADAPTER-XPRO - mikroBUS Adapter**


Suggested change

**Figure 2: ATMBUSADAPTER-XPRO - mikroBUS Adapter**

Has committed the change.

kartben · 2026-02-16T12:39:24Z

boards/shields/mchp_rnbd451_bt/doc/img/same54-with-rnbd451.webp

unused - please drop

Has committed the change.

kartben · 2026-02-16T12:39:55Z

boards/shields/mchp_rnbd451_bt/doc/img/mchp_rnbd451_bt_mikrobus.webp

this should be named exactly like the shield - mchp_rnbd451_bt_mikrobus.webp

Has committed the change.

dts/bindings/gpio/microchip,xpro-header.yaml

nandojve · 2026-02-25T06:53:52Z

ping @JarmouniA

The Xplained Pro layout provide a standard 20 pin header. A board can have one or more headers and can share pins. The extension headers are given names EXTn where n ϵ [1…7], n is determined by which ID pin is connected to the embedded debugger. Signed-off-by: James Liu <James.Liu2@microchip.com>

Add xprpo-header support in sam_e54_xpro Signed-off-by: James Liu <James.Liu2@microchip.com>

Expand SERCOM serial ports in the sam_e54_xpro board. This add and enable sercom0, sercom1 and sercom5 ports which are located in the xplained pro header. It makes use of the microchip,xpro-header to easy use with shields. Signed-off-by: James Liu <James.Liu2@microchip.com>

Add board support for the Microchip RNBD451 shield. This shield is compatible with a development board that includes a mikroBUS socket. Signed-off-by: James Liu <James.Liu2@microchip.com>

sonarqubecloud · 2026-02-26T02:38:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added area: Shields Shields (add-on boards) area: Boards/SoCs labels Oct 22, 2025

zephyrbot requested review from avisconti, erwango, jfischer-no and kartben October 22, 2025 05:55

zephyrbot assigned kartben Oct 22, 2025

nandojve requested review from NhMchp and nandojve October 22, 2025 06:00

JamesLiu-Microchip force-pushed the shield_rnbd451_bt_upstream branch from e09cf21 to 05b00d6 Compare November 5, 2025 07:54

nandojve added this to the v4.4.0 milestone Nov 9, 2025

nandojve requested changes Nov 9, 2025

View reviewed changes

boards/shields/mchp_rnbd451_bt/mchp_rnbd451_bt.overlay Outdated Show resolved Hide resolved

boards/shields/mchp_rnbd451_bt/boards/sam_e54_xpro.overlay Outdated Show resolved Hide resolved

JamesLiu-Microchip force-pushed the shield_rnbd451_bt_upstream branch from 05b00d6 to 0291576 Compare November 10, 2025 06:56

nandojve requested changes Nov 10, 2025

View reviewed changes

boards/shields/mchp_rnbd451_bt/doc/index.rst Outdated Show resolved Hide resolved

boards/shields/mchp_rnbd451_bt/doc/index.rst Outdated Show resolved Hide resolved

kartben reviewed Nov 10, 2025

View reviewed changes

JamesLiu-Microchip force-pushed the shield_rnbd451_bt_upstream branch from 0291576 to a342382 Compare December 15, 2025 06:18

zephyrbot added platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) area: Devicetree Bindings area: GPIO labels Dec 15, 2025

zephyrbot requested review from ArunMCHP, henrikbrixandersen and stephanosio December 15, 2025 06:19

nandojve requested changes Dec 15, 2025

View reviewed changes

boards/microchip/sam/sam_e54_xpro/sam_e54_xpro.dts Outdated Show resolved Hide resolved

boards/shields/mchp_rnbd451_bt/Kconfig.defconfig Outdated Show resolved Hide resolved

boards/shields/mchp_rnbd451_bt/mchp_rnbd451_bt.overlay Show resolved Hide resolved

JamesLiu-Microchip force-pushed the shield_rnbd451_bt_upstream branch from a342382 to 343ebf7 Compare December 16, 2025 02:31

JamesLiu-Microchip force-pushed the shield_rnbd451_bt_upstream branch from 343ebf7 to 481fb8c Compare December 19, 2025 02:00

JamesLiu-Microchip force-pushed the shield_rnbd451_bt_upstream branch from 19fb0e2 to fa9f6a4 Compare January 19, 2026 06:27

nandojve requested changes Jan 23, 2026

View reviewed changes

JamesLiu-Microchip force-pushed the shield_rnbd451_bt_upstream branch from fa9f6a4 to 746bb8d Compare January 26, 2026 01:40

JamesLiu-Microchip force-pushed the shield_rnbd451_bt_upstream branch 2 times, most recently from 705f67f to ddb1d85 Compare February 5, 2026 08:29

nandojve previously approved these changes Feb 8, 2026

View reviewed changes

JarmouniA requested changes Feb 15, 2026

View reviewed changes

kartben requested changes Feb 16, 2026

View reviewed changes

JamesLiu-Microchip dismissed nandojve’s stale review via 3e9702b February 25, 2026 03:12

JamesLiu-Microchip force-pushed the shield_rnbd451_bt_upstream branch from ddb1d85 to 3e9702b Compare February 25, 2026 03:12

zephyrbot requested review from Farsin-Nasar-Microchip, fabin-mchp, mchp-asif and sunil-abraham February 25, 2026 03:14

JamesLiu-Microchip requested review from JarmouniA and kartben February 25, 2026 03:22

kartben previously approved these changes Feb 25, 2026

View reviewed changes

nandojve previously approved these changes Feb 25, 2026

View reviewed changes

JamesLiu-Microchip added 4 commits February 26, 2026 10:04

boards: microchip: sam_e54_xpro: Binding to xprpo-header

40fd9e5

Add xprpo-header support in sam_e54_xpro Signed-off-by: James Liu <James.Liu2@microchip.com>

boards: shields: Add mchp_rnbd451_bt

fd9f88a

Add board support for the Microchip RNBD451 shield. This shield is compatible with a development board that includes a mikroBUS socket. Signed-off-by: James Liu <James.Liu2@microchip.com>

JamesLiu-Microchip dismissed stale reviews from nandojve and kartben via fd9f88a February 26, 2026 02:08

JamesLiu-Microchip force-pushed the shield_rnbd451_bt_upstream branch from 3e9702b to fd9f88a Compare February 26, 2026 02:08

zephyrbot requested review from kartben and nandojve February 26, 2026 02:09

	sercom5_uart_default: sercom5_uart_default {
	sercom5_uart_default: sercom5-uart-default {

Conversation

JamesLiu-Microchip commented Oct 22, 2025

github-actions bot commented Oct 22, 2025

NhMchp commented Oct 22, 2025

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 10, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

nandojve left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nandojve commented Dec 18, 2025

nandojve commented Dec 26, 2025

nandojve left a comment

Choose a reason for hiding this comment

nandojve commented Feb 14, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JarmouniA Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JamesLiu-Microchip Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

JarmouniA Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

JamesLiu-Microchip Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JamesLiu-Microchip Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JamesLiu-Microchip Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

kartben Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

nandojve commented Feb 25, 2026

sonarqubecloud bot commented Feb 26, 2026

Quality Gate passed

Labels

6 participants

JarmouniA Feb 25, 2026 •

edited

Loading

JamesLiu-Microchip Feb 26, 2026 •

edited

Loading

JarmouniA Feb 26, 2026 •

edited

Loading

JamesLiu-Microchip Feb 25, 2026 •

edited

Loading

JamesLiu-Microchip Feb 25, 2026 •

edited

Loading

JamesLiu-Microchip Feb 25, 2026 •

edited

Loading

kartben Feb 16, 2026 •

edited

Loading