-
Notifications
You must be signed in to change notification settings - Fork 454
replace new array calls with array.from #5231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
875d359
to
1411b6c
Compare
1411b6c
to
f5d5863
Compare
jasnell
reviewed
Oct 3, 2025
jasnell
reviewed
Oct 3, 2025
jasnell
reviewed
Oct 3, 2025
f5d5863
to
32f9a08
Compare
jasnell
reviewed
Oct 7, 2025
32f9a08
to
3fed12e
Compare
jasnell
approved these changes
Oct 7, 2025
dario-piotrowicz
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
Co-authored-by: Dario Piotrowicz <dario.piotrowicz@gmail.com>
petebacondarwin
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended by several linters, and reduces complexity due to having a callback with map.