stream-utils improvements #5237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jasnell
commented
Oct 3, 2025
jasnell
commented
- Eliminate duplicative null io stream... there's a kj::NullStream we can use.
- Improve MemoryInputStream in preparation for using it to replace multiple duplicative stream impls (in blob, http, email, etc).
jasnell
force-pushed
the
jasnell/eliminate-duplicated-nulliostream
branch
from
9a12566 to
90175a0
Compare
anonrig
approved these changes
Oct 3, 2025
fhanau
reviewed
Oct 5, 2025
Just use the `kj::NullStream` and avoid allocating new instances on every use.
Improve and expand the implementation of MemoryInputStream. This will soon be used to replace the duplicative stream implementations in: BlobInputStream, EmailPartInputStream, BodyBufferInputStream, and a couple of test stream impls. The improvements here include better handling of pumpTo, and teeing, as well as allowing the stream to hold onto its underlying backing.
jasnell
force-pushed
the
jasnell/eliminate-duplicated-nulliostream
branch
from
90175a0 to
8f9c4a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.