fix: don't show empty autofill popup - #52319
Merged
ckerr merged 2 commits intoJul 14, 2026
Merged
Conversation
Co-authored-by: Noah Gregory <nmggithub@electronjs.org>
A hostile renderer could send values without matching labels and crash the browser process via out-of-range label access in label_at(). Also route the hide through HideAutofillPopup() for consistency and add comments explaining the guards. Co-authored-by: Samuel Attard <sattard@anthropic.com>
5 tasks
trop
Bot
added
42-x-y
backport
ckerr
approved these changes
Jul 14, 2026
ckerr
deleted the
trop/42-x-y-bp-fix-don-t-show-empty-autofill-popup-1783957071824
branch
July 14, 2026 23:11
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52262
See that PR for details.
Notes: Fixed unnecessary autofill popup creation for fields without datalist suggestions, which could cause input latency on macOS.