Skip to content

fix: update dependencies to clean up yarn audit - #234

Merged
MarshallOfSound merged 6 commits into
mainfrom
deps
Oct 31, 2023
Merged

fix: update dependencies to clean up yarn audit#234
MarshallOfSound merged 6 commits into
mainfrom
deps

Conversation

@MarshallOfSound

@MarshallOfSound MarshallOfSound commented Dec 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

BREAKING CHANGE: The minimum supported node version is now node 14

This PR also as a side effect ensures tests can pass / run on M1 hardware.
@MarshallOfSound
MarshallOfSound requested a review from a team December 1, 2022 23:34
@BlackHole1

BlackHole1 commented Dec 2, 2022

Copy link
Copy Markdown
Member

CI failed. Reason: error @continuous-auth/semantic-release-npm@3.0.0: The engine "node" is incompatible with this module. Expected version ">=16 || ^14.17". Got "12.13.1".

Restoration Solutions:

  1. Use --ignore-engines In CI. Since only devDependencies are upgraded, it does not affect the end-users.
  2. Fallback @continuous-auth/semantic-release-npm version
  3. Modifdy https://github.com/electron/get/blob/main/package.json#L26 to >=16
@BlackHole1

BlackHole1 commented Dec 2, 2022

Copy link
Copy Markdown
Member

CI failed again.
image

Optional Chaining was not implemented until after nodejs version 14
@MarshallOfSound
MarshallOfSound force-pushed the deps branch 7 times, most recently from da15130 to de4ca27 Compare December 8, 2022 18:49
MarshallOfSound and others added 2 commits October 30, 2023 23:29
@MarshallOfSound MarshallOfSound changed the title build: update dependencies to clean up yarn audit Oct 31, 2023
BlackHole1
BlackHole1 previously requested changes Oct 31, 2023
View reviewed changes
Comment thread package.json Outdated
Comment thread package.json
@MarshallOfSound @BlackHole1
Update package.json
f113153 
Co-authored-by: Black-Hole <158blackhole@gmail.com>
@MarshallOfSound
MarshallOfSound merged commit 6ab6b88 into main Oct 31, 2023
@MarshallOfSound
MarshallOfSound deleted the deps branch October 31, 2023 18:07
@continuous-auth

continuous-auth Bot commented Oct 31, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀
@Dramaga11 Dramaga11 mentioned this pull request Jun 3, 2024
Merged
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
@sedwin928 sedwin928 mentioned this pull request Jul 26, 2024
Open
@sedwin928 sedwin928 mentioned this pull request Aug 6, 2024
Open
@snyk-io snyk-io Bot mentioned this pull request Aug 12, 2024
Open
This was referenced Aug 29, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released

4 participants

@MarshallOfSound @BlackHole1 @dsanders11 @erickzhao