FF141 adds HTML popover source + force option #27157
Conversation
github-actions
bot
added
data:api
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
api/HTMLElement.json
Outdated
| ], | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false |
There was a problem hiding this comment.
Note, I can't find evidence that they are supported in chrome or Safari, but nor can I find evidence they aren't
There was a problem hiding this comment.
Chrome supports
- the
forceoption since 130: https://github.com/caugner/chromium-releases/blame/v130/third_party/blink/renderer/core/html/html_element.cc#L1409 - the
forceparameter since 116: https://github.com/caugner/chromium-releases/blame/v116/third_party/blink/renderer/core/html/html_element.cc#L1411C19-L1411C32
WebKit supports
- the
forceoption since Safari 18.4 (WebKit/WebKit@899ca0c landed in 621.1.9 before Safari 18.4/WebKit 621.1.15), - the
forceparameter since the beginning, i.e. Safari 17 (see https://github.com/WebKit/WebKit/blame/ecb76a449ffa26cb4da089afe4ee8d7ba90f13a9/Source/WebCore/html/HTMLElement.h#L155).
api/HTMLElement.json
Outdated
| @@ -2862,6 +2862,41 @@ | |||
| "deprecated": false | |||
| } | |||
| }, | |||
| "force": { | |||
There was a problem hiding this comment.
I copied the pattern of source.
For both this and source shouldn't the actual pattern be as below, based on the schema? Or did that change?
| "force": { | |
| "option_force": { |
There was a problem hiding this comment.
Given that force can be both a parameter and an option, and the option came later, we might want to record it as both force_parameter and force_option, to avoid confusion.
There was a problem hiding this comment.
Yes. That is absolutely the right thing to do. I have changed this to match the expected schema and key names.
PS Thanks for doing the research on when these were introduced in chrome/safari
api/HTMLElement.json
Outdated
| @@ -2862,6 +2862,41 @@ | |||
| "deprecated": false | |||
| } | |||
| }, | |||
| "force": { | |||
There was a problem hiding this comment.
Given that force can be both a parameter and an option, and the option came later, we might want to record it as both force_parameter and force_option, to avoid confusion.
api/HTMLElement.json
Outdated
| ], | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false |
There was a problem hiding this comment.
Chrome supports
- the
forceoption since 130: https://github.com/caugner/chromium-releases/blame/v130/third_party/blink/renderer/core/html/html_element.cc#L1409 - the
forceparameter since 116: https://github.com/caugner/chromium-releases/blame/v116/third_party/blink/renderer/core/html/html_element.cc#L1411C19-L1411C32
WebKit supports
- the
forceoption since Safari 18.4 (WebKit/WebKit@899ca0c landed in 621.1.9 before Safari 18.4/WebKit 621.1.15), - the
forceparameter since the beginning, i.e. Safari 17 (see https://github.com/WebKit/WebKit/blame/ecb76a449ffa26cb4da089afe4ee8d7ba90f13a9/Source/WebCore/html/HTMLElement.h#L155).
caugner
changed the title
FF141 supports the
sourceoption toHTMLElement.showPopover()andHTMLElement.togglePopover(), and theforceoption toHTMLElement.togglePopover()in https://bugzilla.mozilla.org/show_bug.cgi?id=1936411This adds the features.
Related docs work can be tracked in mdn/content#40027