Studio: Update wordpress components dependency - #1195
Conversation
gcsecsey
left a comment
gcsecsey
left a comment
There was a problem hiding this comment.
I tested the app and it holistically works as expected after the changes.
I did notice a new warning in the dev console after doing these steps:
- Open the What's New modal from the Help menu, and walk over the screens
- Walk through the tabs of a site
- Try to update a preview site's name
gcsecsey
left a comment
gcsecsey
left a comment
There was a problem hiding this comment.
I did a clean install and launch on the same branch, and I can't reproduce the warning being thrown previously
After doing the same steps, I'm not getting any warnings or errors now:
|
Nice! That is great that the new version is fixing some of those issues. Similarly to Gergely, I did not observe any issues in the UI, just some of the unit tests are failing. |
Nice, thanks. I will take a look at the tests but I will wait for Studio release first before merging this in any case |
…press-components-dependency
| expect( useSnapshots().updateSnapshot ).not.toHaveBeenCalled(); | ||
|
|
||
| // Wait for the modal to be fully closed after the exit animation | ||
| await waitFor( () => { |
There was a problem hiding this comment.
It took me a bit of time to figure out why the tests were failing here. It seems to be related to this PR: WordPress/gutenberg@4e7e9f7
It added some exit animation so we need to wait for the promises to resolve first
3 participants
Related issues
We have last updated this dependency over 6 months ago and now with the renewed focus on core components, it would be good to have the most recent updates and states of all the components in Studio. Additionally, I noticed that there were some fixes added in the new version for the
Guidecomponent that would allow us to remove some code that we added on our end (for example https://github.com/WordPress/gutenberg/pull/65680/files)Proposed Changes
I propose to update
wordpress/componentsdependency.Testing Instructions
npm install && npm startPre-merge Checklist