Skip to content

Studio: Remove unncessary CSS - #1203

Merged
katinthehatsite merged 1 commit into
trunkfrom
fix/remove-unnecesary-css-from-whats-new-modal
Apr 15, 2025
Merged

Studio: Remove unncessary CSS#1203
katinthehatsite merged 1 commit into
trunkfrom
fix/remove-unnecesary-css-from-whats-new-modal

Conversation

@katinthehatsite

Copy link
Copy Markdown
Contributor

Proposed Changes

Since we upgraded wordpress/components dependency in #1195 , this fix is no longer needed and the Done button should be set to 40px height automatically.

Testing Instructions

  • Pull the changes from this branch
  • Start the app with npm start
  • Click on Help > What's new button
  • Navigate to the last page of the Guide component
  • Confirm that the Done button is set to 40px (feel free to compare to the look on trunk as it should remain the same)

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@katinthehatsite katinthehatsite self-assigned this Apr 14, 2025
@katinthehatsite
katinthehatsite requested a review from a team April 14, 2025 20:12

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well for me.

Note that you need to run npm install before starting the app to see the correct button size.

@katinthehatsite
katinthehatsite merged commit 0d6738c into trunk Apr 15, 2025
@katinthehatsite
katinthehatsite deleted the fix/remove-unnecesary-css-from-whats-new-modal branch April 15, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants