Studio: Remove unncessary CSS - #1203
Merged
katinthehatsite merged 1 commit intoApr 15, 2025
Merged
Conversation
wojtekn
approved these changes
Apr 15, 2025
wojtekn
left a comment
Contributor
There was a problem hiding this comment.
It works well for me.
Note that you need to run npm install before starting the app to see the correct button size.
katinthehatsite
deleted the
fix/remove-unnecesary-css-from-whats-new-modal
branch
April 15, 2025 07:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Since we upgraded wordpress/components dependency in #1195 , this fix is no longer needed and the
Donebutton should be set to 40px height automatically.Testing Instructions
npm startHelp > What's newbuttonGuidecomponentDonebutton is set to 40px (feel free to compare to the look on trunk as it should remain the same)Pre-merge Checklist