Skip to content

What's New modal: Fix translations of Next and Previous buttons - #1315

Merged
sejas merged 2 commits into
trunkfrom
fix/whats-new-modal-next-previous-button-translations
May 2, 2025
Merged

What's New modal: Fix translations of Next and Previous buttons#1315
sejas merged 2 commits into
trunkfrom
fix/whats-new-modal-next-previous-button-translations

Conversation

@ivan-ottinger

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

Markup on 2025-05-02 at 17:17:31

Testing Instructions

  1. Check out the PR branch and build the app with npm install && npm start.
  2. Switch your app locale to non-English.
  3. Open the "What's New" modal through the Help → What's New menu.
  4. The Next and Previous buttons should be translated.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@ivan-ottinger ivan-ottinger self-assigned this May 2, 2025
@ivan-ottinger ivan-ottinger changed the title What's New modal: Fix translations of Next and Previous` buttons May 2, 2025
@ivan-ottinger
ivan-ottinger requested a review from a team May 2, 2025 15:27

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivan-ottinger for making these changes. This looks good to me and works well!

CleanShot 2025-05-02 at 16 37 35@2x

@ivan-ottinger

Copy link
Copy Markdown
Contributor Author

Thank you, Gergely!

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. I tested it running npm install && npm start and then clicking Help > What's new. I confirm the buttons Next, Previous are translated

Screenshot 2025-05-02 at 17 34 01

@sejas
sejas merged commit 217c4c7 into trunk May 2, 2025
@sejas
sejas deleted the fix/whats-new-modal-next-previous-button-translations branch May 2, 2025 16:36
@ivan-ottinger

Copy link
Copy Markdown
Contributor Author

Thank you for the review and merging, Antonio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants