Skip to content

Update @wordpress/components to 29.9.0 - #1398

Merged
ivan-ottinger merged 2 commits into
trunkfrom
update/wordpress-components-to-29.9.0
May 15, 2025
Merged

Update @wordpress/components to 29.9.0#1398
ivan-ottinger merged 2 commits into
trunkfrom
update/wordpress-components-to-29.9.0

Conversation

@ivan-ottinger

@ivan-ottinger ivan-ottinger commented May 15, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

Testing Instructions

  1. Check out the PR branch and build the app with npm install && npm start.
  2. Review the app still works as expected. Smoke-test some features, focusing on WordPress core components. We will do a full smoke-testing with the upcoming release anyways.
  3. Change the locale to non-English and open the "What's new" modal from the top Help menu.
  4. The Next and Previous buttons should be still translated (as before).
  5. Ensure there are regressions, nor errors or warnings in the console.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@ivan-ottinger ivan-ottinger self-assigned this May 15, 2025
@ivan-ottinger
ivan-ottinger requested a review from a team May 15, 2025 09:44

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The What's New modal worked as expected for me, also with different translations:

Screenshot 2025-05-15 at 12 30 09 PM

Nice work! I did not spot any further regressions with this update and did not see any console warnings or errors 👍

@nightnei nightnei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and everything works weel 👍
Screenshot 2025-05-15 at 13 25 54

@ivan-ottinger

Copy link
Copy Markdown
Contributor Author

Thank you for your reviews both!

@ivan-ottinger
ivan-ottinger merged commit 8805660 into trunk May 15, 2025
@ivan-ottinger
ivan-ottinger deleted the update/wordpress-components-to-29.9.0 branch May 15, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants