SSL Support: Refactor certificate trust selector - #1325
Merged
Conversation
gavande1
commented
May 5, 2025
gavande1
force-pushed
the
hide/ssl-help-trusted-certificate
branch
from
May 6, 2025 13:22
f889895 to
0169e08
Compare
gavande1
force-pushed
the
hide/ssl-help-trusted-certificate-refactor
branch
from
May 7, 2025 06:25
4faf9d6 to
5926522
Compare
gavande1
force-pushed
the
hide/ssl-help-trusted-certificate
branch
from
May 7, 2025 06:49
0169e08 to
977bc7d
Compare
gavande1
force-pushed
the
hide/ssl-help-trusted-certificate-refactor
branch
from
May 7, 2025 06:50
9332c01 to
3182bd5
Compare
fredrikekelund
left a comment
fredrikekelund
left a comment
Contributor
There was a problem hiding this comment.
This is shaping up nicely 👍 I left a couple of quick suggestions.
1 task
gavande1
force-pushed
the
hide/ssl-help-trusted-certificate-refactor
branch
from
May 7, 2025 09:02
3182bd5 to
bbc9b60
Compare
fredrikekelund
left a comment
fredrikekelund
left a comment
Contributor
There was a problem hiding this comment.
A couple of final tweaks and this should be good to go 👍
We need to add the following to src/stores/index.ts to make the refetchOnFocus option work:
import { setupListeners } from '@reduxjs/toolkit/query';
setupListeners( store.dispatch );
gavande1
commented
May 7, 2025
| error instanceof Error ? error.message : 'Failed to check certificate trust'; | ||
| return { | ||
| error: { data: false, error: errorMessage } as FetchBaseQueryError, | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
@fredrikekelund, Returning error as you suggested was throwing an error in the console. RTK expects errors in current format.
fredrikekelund
approved these changes
May 7, 2025
fredrikekelund
left a comment
fredrikekelund
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a small comment about the structure of the error object returned by checkCertificateTrust 👍
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Contributor
|
The Sentry issue appears to be unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist