SSL Support: Install root certificate directly on Windows instead of opening folder - #1327
Merged
Conversation
gavande1
marked this pull request as ready for review
May 6, 2025 06:14
gavande1
force-pushed
the
hide/ssl-help-trusted-certificate
branch
from
May 6, 2025 13:22
f889895 to
0169e08
Compare
gavande1
force-pushed
the
add/install-ssl-certificate-windows
branch
from
May 6, 2025 13:47
79b84c9 to
d4782aa
Compare
gavande1
force-pushed
the
add/install-ssl-certificate-windows
branch
from
May 7, 2025 06:47
d4782aa to
75ae810
Compare
gavande1
force-pushed
the
hide/ssl-help-trusted-certificate
branch
from
May 7, 2025 06:49
0169e08 to
977bc7d
Compare
gavande1
force-pushed
the
add/install-ssl-certificate-windows
branch
from
May 7, 2025 06:50
75ae810 to
4f0e1d2
Compare
fredrikekelund
left a comment
Contributor
There was a problem hiding this comment.
This is getting there, but I have two comments:
- The thing about not failing silently if
trustRootCAfails. - We should automatically refresh the trust status after
getIpcApi().trustCertificate()finishes executing. After landing #1325, we can do this like so:
onClick={ async () => {
await getIpcApi().trustCertificate();
await dispatch(
certificateTrustApi.util.invalidateTags( [ 'CertificateTrust' ] )
);
} }
gavande1
force-pushed
the
add/install-ssl-certificate-windows
branch
from
May 7, 2025 09:14
4f0e1d2 to
964b4f2
Compare
nightnei
requested changes
May 7, 2025
gavande1
force-pushed
the
add/install-ssl-certificate-windows
branch
from
May 7, 2025 13:14
f2205ef to
6c8aa0c
Compare
Contributor
Author
|
Thanks both of you, @nightnei and @fredrikekelund, for amazing suggestions. The PR is ready to be reviewed again. |
gavande1
commented
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issues
Proposed Changes
Why changes are being made
On Windows, the certificate installation process can be automated. Previously, we opened the folder containing the certificate, requiring manual installation. This PR updates the behavior to call trustRootCA() on Windows, automatically installing the certificate when it’s not trusted.
Testing Instructions
npm startPre-merge Checklist