Studio: Fix incorrect offline message displayed alongside "delete site" link - #141
Merged
Merged
Conversation
kozer
reviewed
May 17, 2024
Contributor
kozer
reviewed
May 17, 2024
Contributor
|
@katinthehatsite , while I was testing it, I found a bug! It's not related to you ( Happens on the trunk as well ). I'll approve! Nice work! |
kozer
approved these changes
May 17, 2024
SiobhyB
approved these changes
May 17, 2024
SiobhyB
left a comment
There was a problem hiding this comment.
This works perfectly for me, thanks for fixing Kat 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes https://github.com/Automattic/dotcom-forge/issues/7144
Proposed Changes
This PR does the following:
Delete sitelink to be displayed only when the user has a local site with snapshotsTesting Instructions
nvm use && npm install && npm startSettingstab for a local site that has a demo site associated with itDelete sitelink is disabled and the offline message appears:Delete sitelink is available underSettingstabDelete sitePre-merge Checklist