Skip to content
Prev Previous commit
Next Next commit
Simplify the logic
  • Loading branch information
Kateryna Kodonenko
Kateryna Kodonenko committed May 17, 2024
commit be2bb60f432e64af2548ba41fa3f3e073f3ccd02
19 changes: 5 additions & 14 deletions src/hooks/use-site-details.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ interface SiteDetailsContext {
startServer: ( id: string ) => Promise< void >;
stopServer: ( id: string ) => Promise< void >;
stopAllRunningSites: () => Promise< void >;
deleteSite: ( id: string, removeLocal: boolean, deleteSnapshots?: boolean ) => Promise< void >;
deleteSite: ( id: string, removeLocal: boolean ) => Promise< void >;
loadingServer: Record< string, boolean >;
loadingSites: boolean;
isDeleting: boolean;
Expand Down Expand Up @@ -133,24 +133,15 @@ function useDeleteSite() {
async (
siteId: string,
removeLocal: boolean,
snapshots: Snapshot[],
deleteSnapshots?: boolean
snapshots: Snapshot[]
): Promise< SiteDetails[] | undefined > => {
if ( ! siteId ) {
return;
}

Comment thread
kozer marked this conversation as resolved.
Outdated
// Default deleteSnapshots to true
const shouldDeleteSnapshots = deleteSnapshots ?? true;

let allSiteRemovePromises;
if ( shouldDeleteSnapshots ) {
allSiteRemovePromises = Promise.allSettled(
snapshots.map( ( snapshot ) => deleteSnapshot( snapshot ) )
);
} else {
allSiteRemovePromises = Promise.resolve( [] );
}
const allSiteRemovePromises = Promise.allSettled(
snapshots.map( ( snapshot ) => deleteSnapshot( snapshot ) )
);

try {
setIsLoading( ( loading ) => ( { ...loading, [ siteId ]: true } ) );
Expand Down