Skip to content

Force What's New modal to display in 1.6.4 (due to the new survey card) - #2094

Merged
ivan-ottinger merged 1 commit into
trunkfrom
update/force-whats-new-modal-display
Nov 20, 2025
Merged

Force What's New modal to display in 1.6.4 (due to the new survey card) #2094
ivan-ottinger merged 1 commit into
trunkfrom
update/force-whats-new-modal-display

Conversation

@ivan-ottinger

@ivan-ottinger ivan-ottinger commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Related issues

  • Related discussion p1763563680649809-slack-C06DRMD6VPZ

Proposed Changes

  • set FORCE_WHATS_NEW_WHEN_PATCH_CHANGED constant to true temporarily

We will put it back to false once the 1.6.4 version is released (or keep it in for longer - depending on the discussion).

Testing Instructions

  1. Check out the PR branch and build the app with npm install && npm start.
  2. Change the lastSeenVersion in your appdata-v1.json to an earlier patch version.
  3. When the app starts, the "What's New" modal should render (even though we are bumping just the patch version when the modal wouldn't normally show up).

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@ivan-ottinger ivan-ottinger self-assigned this Nov 19, 2025
@ivan-ottinger
ivan-ottinger marked this pull request as ready for review November 19, 2025 15:18
@ivan-ottinger
ivan-ottinger requested a review from a team November 19, 2025 15:19

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

CleanShot 2025-11-19 at 16 34 26@2x
@github-actions

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 76d6283 vs trunk

site-editor

Metric trunk 76d6283 Diff Change
load 16260.00 ms 15148.00 ms -1112.00 ms 🟢 -6.8%

site-startup

Metric trunk 76d6283 Diff Change
siteCreation 29364.00 ms 27244.00 ms -2120.00 ms 🟢 -7.2%
siteStartup 12117.00 ms 11128.00 ms -989.00 ms 🟢 -8.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@nightnei nightnei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ivan-ottinger
ivan-ottinger merged commit 8af4165 into trunk Nov 20, 2025
11 checks passed
@ivan-ottinger
ivan-ottinger deleted the update/force-whats-new-modal-display branch November 20, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants