Skip to content

Remove survey from What's New modal - #2205

Merged
gcsecsey merged 2 commits into
trunkfrom
update/remove-survey
Dec 8, 2025
Merged

Remove survey from What's New modal#2205
gcsecsey merged 2 commits into
trunkfrom
update/remove-survey

Conversation

@gcsecsey

@gcsecsey gcsecsey commented Dec 5, 2025

Copy link
Copy Markdown
Member

Related issues

Related discussion p1764942033232509/1764937358.324989-slack-C04GESRBWKW

Proposed Changes

Testing Instructions

  • Change the lastSeenVersion in your appdata-v1.json to an earlier patch version.
  • Start Studio
  • Check that the "What's New" modal is not rendered
  • Open "What's New" modal
  • Confirm the survey entry is removed

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@gcsecsey
gcsecsey requested a review from a team December 5, 2025 14:01
@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 4cd4220 vs trunk

site-editor

Metric trunk 4cd4220 Diff Change
load 11346.00 ms 13642.00 ms +2296.00 ms 🔴 20.2%

site-startup

Metric trunk 4cd4220 Diff Change
siteCreation 16261.00 ms 15203.00 ms -1058.00 ms 🟢 -6.5%
siteStartup 7948.00 ms 6929.00 ms -1019.00 ms 🟢 -12.8%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@ivan-ottinger ivan-ottinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up, Gergely!

The change looks good and works correctly: the modal no longer displays the survey and it does not open automatically for patch version changes.

Image

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good and work as expected 👍

@gcsecsey
gcsecsey merged commit c809981 into trunk Dec 8, 2025
10 of 11 checks passed
@gcsecsey
gcsecsey deleted the update/remove-survey branch December 8, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants