Skip to content

Add wpcom to onboarding - #2139

Merged
nightnei merged 25 commits into
trunkfrom
addWpComToOnboarding
Nov 28, 2025
Merged

Add wpcom to onboarding#2139
nightnei merged 25 commits into
trunkfrom
addWpComToOnboarding

Conversation

@nightnei

@nightnei nightnei commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

With this PR we are adding wpcom as option for onboarding step

Testing Instructions

  1. Open appdata-v1.json, set "onboardingCompleted": false and remove authToken if you have it
  2. Open Studio
  3. Assert that you see the next screen
    Screenshot 2025-11-27 at 15 11 14
  4. Click on "Skip"
  5. Assert that onboarding is closed and you see initial Studio's empty page for creating new site
  6. Repeat 1-st step to clean Studio
  7. Click on "Create a free account"
  8. Assert that you were landed to the appropriate wpcom page
  9. Next, click on Log in and proceed
  10. Assert that you landed to Studio and you see again Studio's empty page
@nightnei
nightnei requested review from a team and sejas November 27, 2025 15:13
@nightnei nightnei self-assigned this Nov 27, 2025
@nightnei
nightnei marked this pull request as ready for review November 27, 2025 15:14

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!, Love the PRs that remove so much code, now the flows are even simpler.
We can tackle the exact copy of the onboarding screen as part of STU-1058
I drafted a PR to replace the empty screen with the Add site options flow here #2149

oauth-onboarding.mp4

@gavande1 gavande1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and it works as described. LGTM 👍

Image Image
@github-actions

github-actions Bot commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing f579b7b vs trunk

site-editor

Metric trunk f579b7b Diff Change
load 17016.00 ms 15958.00 ms -1058.00 ms 🟢 -6.2%

site-startup

Metric trunk f579b7b Diff Change
siteCreation 19340.00 ms 19527.00 ms +187.00 ms 🔴 1.0%
siteStartup 6978.00 ms 7945.00 ms +967.00 ms 🔴 13.9%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@nightnei
nightnei merged commit 4b3b29c into trunk Nov 28, 2025
9 checks passed
@nightnei
nightnei deleted the addWpComToOnboarding branch November 28, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants