Remove backward compatibility for onboarding metrics tests - #2156
Merged
Conversation
Contributor
📊 Performance Test ResultsComparing 1a82be3 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
sejas
approved these changes
Dec 1, 2025
sejas
left a comment
sejas
left a comment
Member
There was a problem hiding this comment.
Changes in e2e look good and confirm the pass correctly.
wojtekn
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
We replaced onboarding in this PR, but we run metrics on PR's branch and trunk branch to compare, so in that PR we added backward compatibility to metrics. And in this PR we are removing it.
Testing Instructions
All tests on this PR should be green