Skip to content

Remove quick blink when starting Studio onboarding - #2192

Merged
sejas merged 4 commits into
trunkfrom
update/stu-1091-studio-remove-quick-blink-when-rendering-onboarding
Dec 4, 2025
Merged

Remove quick blink when starting Studio onboarding#2192
sejas merged 4 commits into
trunkfrom
update/stu-1091-studio-remove-quick-blink-when-rendering-onboarding

Conversation

@sejas

@sejas sejas commented Dec 4, 2025

Copy link
Copy Markdown
Member

Related issues

Proposed Changes

  • Avoid showing the zero sites layout when loading the onboarding.

Testing Instructions

  • Remove your sites, log out, and set onboardingCompleted: false in your Studio config file.
  • Run npm start or npm run make
  • Observe that a empty dark screen while loading until it loads the onboarding.
  • Press cmd+r multiple times
  • Confirm the Sites layout with left main sidebar doesn't appear.
remove-blink-when-loading-onboarding.mp4

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas
sejas requested a review from a team December 4, 2025 13:30
@sejas sejas self-assigned this Dec 4, 2025
@sejas
sejas marked this pull request as draft December 4, 2025 14:01
@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 1ea436f vs trunk

site-editor

Metric trunk 1ea436f Diff Change
load 10984.00 ms 11087.00 ms +103.00 ms 🔴 0.9%

site-startup

Metric trunk 1ea436f Diff Change
siteCreation 21574.00 ms 21798.00 ms +224.00 ms 🔴 1.0%
siteStartup 9032.00 ms 10039.00 ms +1007.00 ms 🔴 11.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@sejas
sejas marked this pull request as ready for review December 4, 2025 15:22

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I confirmed the issue on trunk and the fix here, nice catch!

@sejas
sejas merged commit 60108f1 into trunk Dec 4, 2025
10 checks passed
@sejas
sejas deleted the update/stu-1091-studio-remove-quick-blink-when-rendering-onboarding branch December 4, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants