Skip to content

Remove quick blink when starting Studio onboarding #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sejas merged 4 commits into from
Dec 4, 2025
Merged

Remove quick blink when starting Studio onboarding #2192

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a176fe
Render blank page when loading onboarding status to avoid blinking
sejas Dec 4, 2025
cb5a0bd
update initial loading state in tests
sejas Dec 4, 2025
2b54bb8
Fix app tests to indicate that onboarding loading has finished
sejas Dec 4, 2025
06cd315
Remove unused import
sejas Dec 4, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update initial loading state in tests
  • Loading branch information
@sejas
sejas committed Dec 4, 2025
commit cb5a0bd62bca5d5546ac86c96ecd005d19533fc3
6 changes: 3 additions & 3 deletions src/stores/tests/onboarding-slice.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe( 'onboarding-slice', () => {
it( 'should have correct initial state', () => {
const state = store.getState();
expect( selectOnboardingCompleted( state ) ).toBe( false );
expect( selectOnboardingLoading( state ) ).toBe( false );
expect( selectOnboardingLoading( state ) ).toBe( true );
} );
} );

Expand Down Expand Up @@ -174,9 +174,9 @@ describe( 'onboarding-slice', () => {
} );

it( 'should select onboarding loading state correctly', () => {
// Initial state should be false
// Initial state should be true
let state = store.getState();
expect( selectOnboardingLoading( state ) ).toBe( false );
expect( selectOnboardingLoading( state ) ).toBe( true );

// Mock the API to trigger loading state
mockIpcApi.getOnboardingData.mockResolvedValue( true );
Expand Down