Skip to content

Studio: Sync size calculator ignores database when all files are selected - #2199

Merged
katinthehatsite merged 4 commits into
trunkfrom
fix/delecting-database
Dec 5, 2025
Merged

Studio: Sync size calculator ignores database when all files are selected#2199
katinthehatsite merged 4 commits into
trunkfrom
fix/delecting-database

Conversation

@katinthehatsite

Copy link
Copy Markdown
Contributor

Related issues

Fixes STU-1104

Proposed Changes

This PR ensure that the database size selection is always correctly displayed in the sync modal.

Testing Instructions

  • Pull the changes from this branch
  • Navigate to the Sync tab
  • Connect a site from the Sync modal
  • Click on the Push button
  • Select all the files and the database
  • Observe the number in the progress bar
  • Deselect database
  • Confirm that the number goes down
  • Try selecting only specific files and database
  • Test and confirm that the number goes down when you deselect database and goes up when you select it again
Screenshot 2025-12-05 at 11 48 41 AM Screenshot 2025-12-05 at 11 49 37 AM

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@katinthehatsite katinthehatsite self-assigned this Dec 5, 2025
@katinthehatsite
katinthehatsite requested a review from a team December 5, 2025 10:58
@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing b5839a3 vs trunk

site-editor

Metric trunk b5839a3 Diff Change
load 9434.00 ms 9216.00 ms -218.00 ms 🟢 -2.3%

site-startup

Metric trunk b5839a3 Diff Change
siteCreation 13267.00 ms 14201.00 ms +934.00 ms 🔴 7.0%
siteStartup 5958.00 ms 5971.00 ms +13.00 ms 🔴 0.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this @katinthehatsite! 🙌

The changes look good to me and the calculation seems correct to me in all scenarios

CleanShot.2025-12-05.at.13.35.29.mp4
@gcsecsey

gcsecsey commented Dec 5, 2025

Copy link
Copy Markdown
Member

I restarted the e2e tests because the failing Overview customize links › Block theme customize shortcut links › opens Navigation test seems flaky and irrelevant to these changes.

@katinthehatsite

Copy link
Copy Markdown
Contributor Author

I restarted the e2e tests because the failing Overview customize links › Block theme customize shortcut links › opens Navigation test seems flaky and irrelevant to these changes.

Nice, thanks a lot 🙇

@katinthehatsite
katinthehatsite merged commit 83ec906 into trunk Dec 5, 2025
9 checks passed
@katinthehatsite
katinthehatsite deleted the fix/delecting-database branch December 5, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants