Skip to content

Studio: Sync size calculator ignores database when all files are selected #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katinthehatsite merged 4 commits into from
Dec 5, 2025
Merged

Studio: Sync size calculator ignores database when all files are selected #2199

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9711a45
Make sure database deselection and selection works correctly
Dec 5, 2025
ba41f07
Add back removed code
Dec 5, 2025
3b6eb91
Remove empty line
Dec 5, 2025
9847bfc
Fix empty lines
Dec 5, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/modules/sync/hooks/use-selected-items-push-size.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,25 @@ export function useSelectedItemsPushSize(
);

const processNodeRecursively = ( node: TreeNode, pathPrefix: string[] ): void => {
// Always skip the database folder - it's handled separately via the sqls node
if ( node.name === 'database' ) {
return;
}

if ( node.checked ) {
// If the node is fully checked, get its entire size
if ( node.type === 'file' ) {
sizePromises.push( getIpcApi().getFileSize( siteId, [ ...pathPrefix, node.name ] ) );
} else {
if ( node.name === 'mu-plugins' && node.children ) {
} else if ( node.name === 'wp-content' || node.name === 'mu-plugins' ) {
// For wp-content and mu-plugins, always process children to properly skip database
if ( node.children ) {
for ( const child of node.children ) {
processNodeRecursively( child, [ ...pathPrefix, node.name ] );
}
} else {
sizePromises.push(
getIpcApi().getDirectorySize( siteId, [ ...pathPrefix, node.name ] )
);
}
} else {
sizePromises.push(
getIpcApi().getDirectorySize( siteId, [ ...pathPrefix, node.name ] )
);
}
} else if ( node.indeterminate && node.children ) {
// If the node is indeterminate, process its children recursively
Expand Down