Fix thumbnail not loading for newly created sites (approach 1) - #2474
Closed
ivan-ottinger wants to merge 3 commits into
Closed
Fix thumbnail not loading for newly created sites (approach 1)#2474ivan-ottinger wants to merge 3 commits into
ivan-ottinger wants to merge 3 commits into
Conversation
When a new site was created, the thumbnail would show "Preview unavailable" until the user navigated away and back. This happened because: 1. The img element would try to load with an empty src before thumbnail data arrived, triggering onError and setting isThumbnailError to true 2. Once isThumbnailError was true, the img was replaced by a div, so onLoad could never fire to reset the error state when data arrived This fix: - Adds thumbnailLoadErrors tracking at the context level to distinguish between "no data yet" and "failed to load" - Resets the local error state when a new thumbnail load starts - Shows the loading skeleton for running sites until thumbnail data arrives or a load error occurs Fixes STU-1212 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ivan-ottinger
force-pushed
the
fix/STU-1212-newly-added-site-thumbnail
branch
from
January 27, 2026 11:01
0586f39 to
470b21e
Compare
Contributor
Author
|
Closing in favor of #2484. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
thumbnailLoadErrorstracking at the context level inuse-theme-details.tsxuseEffectto reset local error state when thumbnail loading startsTest plan
Fixes STU-1212
🤖 Generated with Claude Code